pig-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ashutosh Chauhan (JIRA)" <j...@apache.org>
Subject [jira] Commented: (PIG-1292) Interface Refinements
Date Fri, 12 Mar 2010 19:31:29 GMT

    [ https://issues.apache.org/jira/browse/PIG-1292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12844632#action_12844632
] 

Ashutosh Chauhan commented on PIG-1292:
---------------------------------------

One reason for not putting it in LoadFunc is to keep loadfunc simple and not have such highly
specific methods in there. We want to move such specialized capabilities away from LoadFunc
into their own interfaces. This is also the reason PIG-966 decided to split LoadFunc into
separate interfaces like LoadPushDown, LoadCaster, LoadMetaData etc. and not put all of them
in LoadFunc. This frees loadfunc implementers from not thinking about them, if they don't
want to. And if one wants to have such specific capability in his loader, he has to think
about it anyway whether its in loadfunc or in its own interface. 

That said, I agree having boolean return value for the method seems to be confusing, so I
agree method return value should be void.

> Interface Refinements
> ---------------------
>
>                 Key: PIG-1292
>                 URL: https://issues.apache.org/jira/browse/PIG-1292
>             Project: Pig
>          Issue Type: Bug
>    Affects Versions: 0.7.0
>            Reporter: Ashutosh Chauhan
>            Assignee: Ashutosh Chauhan
>             Fix For: 0.7.0
>
>         Attachments: pig-interfaces.patch
>
>
> A loader can't implement both OrderedLoadFunc and IndexableLoadFunc, as both are abstract
classes instead of being interfaces.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message