pig-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Olga Natkovich (JIRA)" <j...@apache.org>
Subject [jira] Commented: (PIG-1166) A bit change of the interface of Tuple & DataBag ( make the set and append method return this)
Date Thu, 24 Dec 2009 17:16:29 GMT

    [ https://issues.apache.org/jira/browse/PIG-1166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12794461#action_12794461
] 

Olga Natkovich commented on PIG-1166:
-------------------------------------

The warnings in html files are ok.

Also, since this is an incompatible change we need to discuss this on the user list. This
can cause issues for people who have their own implementation of tuples and we need to find
out if those people exist first.

> A bit change of the interface of Tuple & DataBag ( make the set and append method
return this)
> ----------------------------------------------------------------------------------------------
>
>                 Key: PIG-1166
>                 URL: https://issues.apache.org/jira/browse/PIG-1166
>             Project: Pig
>          Issue Type: Improvement
>            Reporter: Jeff Zhang
>            Assignee: Jeff Zhang
>            Priority: Minor
>         Attachments: Pig_1166.patch
>
>
> When people write unit test for UDF, they always need to build a tuple or bag. If we
change the interface of Tuple and DataBag,  make the set and append method return this, it
can decrease the code size.  e.g. Now people have to write the following code to build a Tuple:
> {code}
> Tuple tuple=TupleFactory.getInstance().newTuple(3);
> tuple.set(0,"item_0");
> tuple.set(1,"item_1");
> tuple.set(2,"item_2");
> {code}
> If we change the interface,  make the set and append method return this, we can rewrite
the above code like this:
> {code}
> Tuple tuple=TupleFactory.getInstance().newTuple(3);
> tuple.set(0,"item_0").set(1,"item_1").set(2,"item_2");
> {code}
> This interface change won't have back compatibility problem and I think there's no performance
problem too.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message