pig-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dmitriy V. Ryaboy (JIRA)" <j...@apache.org>
Subject [jira] Commented: (PIG-1036) Fragment-replicate left outer join
Date Wed, 28 Oct 2009 23:21:59 GMT

    [ https://issues.apache.org/jira/browse/PIG-1036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12771192#action_12771192
] 

Dmitriy V. Ryaboy commented on PIG-1036:
----------------------------------------

This is in the old POFRJoin too, but looking at the constructors, there's a lurking NPE:

{code}
    public POFRJoin(OperatorKey k) throws PlanException, ExecException {
        this(k,-1,null, null, null, null, -1, false);
     }

[...]
 public POFRJoin(OperatorKey k, int rp, List<PhysicalOperator> inp, 
    List<List<PhysicalPlan>> ppLists, List<List<Byte>> keyTypes, 
    FileSpec[] replFiles, int fragment, boolean isLeftOuter) throws ExecException{
        super(k,rp,inp);
        
        phyPlanLists = ppLists;
        this.fragment = fragment;
        this.keyTypes = keyTypes;
        this.replFiles = replFiles;
        replicates = new Map[ppLists.size()]; // BANG
[...]
{code}

size() is getting called on an object that might be null.
Perhaps input list, ppLists, keyTypes, and FileSpec[] should be initialized to empty objects
instead of nulls when they are not set?



> Fragment-replicate left outer join
> ----------------------------------
>
>                 Key: PIG-1036
>                 URL: https://issues.apache.org/jira/browse/PIG-1036
>             Project: Pig
>          Issue Type: New Feature
>            Reporter: Olga Natkovich
>            Assignee: Ankit Modi
>         Attachments: LeftOuterFRJoin.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message