pig-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Daniel Dai (JIRA)" <j...@apache.org>
Subject [jira] Updated: (PIG-936) making dump and PigDump independent from Tuple.toString
Date Wed, 02 Sep 2009 18:40:32 GMT

     [ https://issues.apache.org/jira/browse/PIG-936?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel

Daniel Dai updated PIG-936:

    Attachment: Pig_936_2.Patch

Hi, Jeff,
It is fine to make patch on Windows. "Stripping trailing CRs from patch" does fail the patch.
The problem is PigDump.java, which is now surprisingly in Windows format (You can see the
tailing ^M if you open in vi). If you convert PigDump.java into Unix format (by using dos2unix),
then your patch can be applied. I attached the patch again. The only change is that it will
convert PigDump.java into Unix as well, so it can be applied to trunk.

I also reviewed the patch. It looks good to me. I am fine with the putting TupleFormat and
BagFormat into package "org.apache.pig.impl.util". I will commit it shortly if no other comments.

> making dump and PigDump independent from Tuple.toString
> -------------------------------------------------------
>                 Key: PIG-936
>                 URL: https://issues.apache.org/jira/browse/PIG-936
>             Project: Pig
>          Issue Type: Bug
>    Affects Versions: 0.3.0
>            Reporter: Olga Natkovich
>            Assignee: Jeff Zhang
>             Fix For: 0.4.0
>         Attachments: Pig_936.Patch, Pig_936_2.Patch
> Since Tuple is an interface, a toString implementation can change from one tuple implementation
to the next. This means that format of dump and PigDump will be different depending on the
tuples processed. This could be quite confusing to the users.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message