Return-Path: Delivered-To: apmail-hadoop-pig-dev-archive@www.apache.org Received: (qmail 94209 invoked from network); 6 Jan 2009 00:08:32 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 6 Jan 2009 00:08:32 -0000 Received: (qmail 30389 invoked by uid 500); 6 Jan 2009 00:08:31 -0000 Delivered-To: apmail-hadoop-pig-dev-archive@hadoop.apache.org Received: (qmail 30289 invoked by uid 500); 6 Jan 2009 00:08:31 -0000 Mailing-List: contact pig-dev-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: pig-dev@hadoop.apache.org Delivered-To: mailing list pig-dev@hadoop.apache.org Received: (qmail 30278 invoked by uid 99); 6 Jan 2009 00:08:31 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 05 Jan 2009 16:08:31 -0800 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 06 Jan 2009 00:08:30 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 2F933234C47E for ; Mon, 5 Jan 2009 15:59:44 -0800 (PST) Message-ID: <1733286039.1231199984180.JavaMail.jira@brutus> Date: Mon, 5 Jan 2009 15:59:44 -0800 (PST) From: "Olga Natkovich (JIRA)" To: pig-dev@hadoop.apache.org Subject: [jira] Updated: (PIG-580) PERFORMANCE: Combiner should also be used when there are distinct aggregates in a foreach following a group provided there are no non-algebraics in the foreach In-Reply-To: <332479277.1230577244766.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/PIG-580?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Olga Natkovich updated PIG-580: ------------------------------- Resolution: Fixed Status: Resolved (was: Patch Available) patch committed; thanks, pradeep > PERFORMANCE: Combiner should also be used when there are distinct aggregates in a foreach following a group provided there are no non-algebraics in the foreach > ---------------------------------------------------------------------------------------------------------------------------------------------------------------- > > Key: PIG-580 > URL: https://issues.apache.org/jira/browse/PIG-580 > Project: Pig > Issue Type: Improvement > Affects Versions: types_branch > Reporter: Pradeep Kamath > Assignee: Pradeep Kamath > Fix For: types_branch > > Attachments: PIG-580-v2.patch, PIG-580.patch > > > Currently Pig uses the combiner only when there is foreach following a group when the elements in the foreach generate have the following characteristics: > 1) simple project of the "group" column > 2) Algebraic UDF > The above conditions exclude use of the combiner for distinct aggregates - the distinct operation itself is combinable (irrespective of whether it feeds to an algebraic or non algebraic udf). So if the following foreach should also be combinable: > {code} > .. > b = group a by $0; > c = foreach b generate { x = distinct a; generate group, COUNT(x), SUM(x.$1) } > {code} > The combiner optimizer should cause the distinct to be combined and the final combine output should feed the COUNT() and SUM() in the reduce. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.