pig-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Craig Macdonald (JIRA)" <j...@apache.org>
Subject [jira] Commented: (PIG-18) Making Pig work with HOD 0.4 and hadoop 0.16
Date Fri, 07 Mar 2008 01:40:58 GMT

    [ https://issues.apache.org/jira/browse/PIG-18?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12576006#action_12576006

Craig Macdonald commented on PIG-18:

Hi Olga,

Some comments/questions on this patch:

1. fixUpDomain() still patches non FQ hostnames to be in the domain .inktomisearch.com. Can
this patch resolve this? Perhaps this can become a property that PIG-111 uses?

DataInputStream err = new DataInputStream(p.getErrorStream());
String errMsg = new String();
try {
errMsg = err.readUTF();

This doesnt look quite right. DataInput/DataOutputStreams are a Java specific form of Data
IO, not generally compatible with other platforms. Indeed readUTF expects first a number telling
it how long the String is.

Perhaps this is more appropriate?

String errMsg;
BufferedReader br = new BufferedReader(new InputStreamReader(p.getErrorStream()));
errMsg = br.readLine();

3. How doe hod work over an SSH connection. You ssh to connect to HOD, but your passing a
directory that is on the local node. How does HOD read/write to that?

4. hod is assumed to be on the user's path?

Overall, looks much better :-)


> Making Pig work with HOD 0.4 and hadoop 0.16
> --------------------------------------------
>                 Key: PIG-18
>                 URL: https://issues.apache.org/jira/browse/PIG-18
>             Project: Pig
>          Issue Type: Bug
>          Components: impl
>            Reporter: Olga Natkovich
>            Assignee: Olga Natkovich
>            Priority: Critical
>         Attachments: PIG-18.patch
> Pig needs to work with the soon to be released hadoop on demand (HOD) version.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message