Mailing-List: contact pig-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: pig-dev@incubator.apache.org
Message-ID: <179452040.1204305291708.JavaMail.jira@brutus>
Date: Fri, 29 Feb 2008 09:14:51 -0800 (PST)
From: "Benjamin Francisoud (JIRA)" <jira@apache.org>
To: pig-dev@incubator.apache.org
Subject: [jira] Commented: (PIG-119) test suite improvements
In-Reply-To: <79296087.1203898372504.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/PIG-119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12573848#action_12573848 ] 

Benjamin Francisoud commented on PIG-119:
-----------------------------------------

* Phase 1

What about using [Test NG |http://testng.org/doc/documentation-main.html#test-groups] annotations to define test groups ?
{code:java}
public class Test1 {
  @Test(groups = { "local" })
  public void testMethod1() {
  }
  @Test(groups = {"mapreduce"} )
  public void testMethod2() {
  }
  @Test(groups = { "local", "mapreduce" }) // both
  public void testMethod3() {
  }
}{code}


* Phase 2
cool :)

* Phase 3
Definitively +1

> test suite improvements
> -----------------------
>
>                 Key: PIG-119
>                 URL: https://issues.apache.org/jira/browse/PIG-119
>             Project: Pig
>          Issue Type: Improvement
>            Reporter: Stefan Groschupf
>            Priority: Critical
>
> From my point of view a test suite is very important for a open source project. As better and easier to use it is, as more people can easy contribute and fix bugs. 
> With this in mind I see some space for improvement in the test suite for pig. Here my suggestions, I would love to work on that in case we all agree on the points.
> Phase 1:
> + it should be possible to switch a test mode that defines if pig runs in local mode, mini cluster or big cluster.
> ++ ant test -Dtest.mode=local or -Dtest.mode=mapreduce or -Dtest.mode=mapreduce -Dcluster=myJobTracker
> ++ default should be local
> Phase 2:
> + setup a hudson ci build, run minicluster once a day, run local mode after each checkin.
> Phase 3:
> cleanup the test package, general standard is that each test should be in the same package as the class that is tested.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.