pig-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Stefan Groschupf (JIRA)" <j...@apache.org>
Subject [jira] Commented: (PIG-68) Improving build.xml in many ways :)
Date Fri, 22 Feb 2008 23:45:19 GMT

    [ https://issues.apache.org/jira/browse/PIG-68?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12571643#action_12571643
] 

Stefan Groschupf commented on PIG-68:
-------------------------------------

I just tried the build file again. I get a set of wanring, however all classes compile.
The 18 duplicate class error you get means you have a collision in the name space. Means somehow
some classes exists twice in your classpath. My guess is you have the generated classes still
in your project.
Please make sure you do a ant clean before you patch the build file or please delete the javacc
generated files manually.
Also after patching you need to add src-gen to the classpath of your IDE in case  you use
one.



> Improving build.xml in many ways :)
> -----------------------------------
>
>                 Key: PIG-68
>                 URL: https://issues.apache.org/jira/browse/PIG-68
>             Project: Pig
>          Issue Type: Improvement
>    Affects Versions: 0.1.0
>            Reporter: Benjamin Francisoud
>            Priority: Minor
>         Attachments: build.xml, build.xml-PIG-68-v01.patch, build.xml-PIG-68-v02.patch,
build.xml-PIG-68-v03.patch, build.xml-PIG-68-v04.patch, build.xml-PIG-68-v05.patch, build.xml-PIG-68-v06-SG.patch,
build.xml-PIG-68-v07-SG.patch, out
>
>
> The build file can be improve in many ways:
> * add revision number to pig.jar name (like: pig-r1234.jar)
> * put pig.jar in the dist dir
> * "clean" target leave a "depend" folder undeleted
> * use a regexp to delete files in "org\apache\pig\impl\logicalLayer\parser" folder instead
of listing all files one by one that you want to delete
> * put all artifacts (classes, jar, etc...) in the dist folder so that when doing clean
you just need to specify dist
> * provide a description for targets (for "ant -projecthelp" command)
> * use spaces or tabs but not both (spaces are better for patch and diff in my opinion)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message