Mailing-List: contact commits-help@pig.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@pig.apache.org
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
From: Apache Wiki <wikidiffs@apache.org>
To: Apache Wiki <wikidiffs@apache.org>
Date: Wed, 06 Oct 2010 23:54:03 -0000
Message-ID: <20101006235403.7063.50588@eosnew.apache.org>
Subject: =?utf-8?q?=5BPig_Wiki=5D_Update_of_=22HowToCommit=22_by_AlanGates?=

Dear Wiki user,

You have subscribed to a wiki page or wiki category on "Pig Wiki" for chang=
e notification.

The "HowToCommit" page has been changed by AlanGates.
http://wiki.apache.org/pig/HowToCommit?action=3Ddiff&rev1=3D7&rev2=3D8

--------------------------------------------------

  =

  ##The first act of a new committer is typically to add their name to the =

  ##[WWW] credits page. This requires changing the XML source in =

- ##src/docs/src/documentation/content/xdocs/credits.xml, running =

+ ##src/docs/src/documentation/content/xdocs/whoweare.xml, running =

  ##forrest to regenerate the site(cd src/docs/ ; forrest site), manually =

  ##copying the modified pages to docs/ (cp build/site/credits.* =

  ##../../docs/), committing these changes, and finally, on =

@@ -23, +23 @@

  =

  =3D=3D Review =3D=3D
  =

- Hadoop committers should, as often as possible, attempt to review =

+ Pig committers should, as often as possible, attempt to review =

  patches submitted by others. Ideally every submitted patch will get =

  reviewed by a committer within a few days. If a committer reviews a =

  patch they've not authored, and believe it to be of sufficient quality, =

@@ -39, +39 @@

  =

  =3D=3D Reject =3D=3D
  Patches should be rejected which do not adhere to the guidelines in =

- HowToContribute and to the [[http://wiki.apache.org/lucene-hadoop/CodeRev=
iewChecklist|CodeReviewChecklist]]. Committers =

+ HowToContribute.  Committers =

  should always be polite to contributors and try to instruct and =

  encourage them to contribute better patches. If a committer wishes =

  to improve an unacceptable patch, then it should first be rejected, =

  and a new patch should be attached by the committer for review.
  =

  Patches are rejected by editing the issue and un-setting the 'Patch Avail=
able' checkbox and adding a comment that politely details the reason(s) for=
 rejection.
- =

- (Pig needs to add its own code review checklist, but for now we are using=
 hadoop's.)
  =

  =3D=3D Commit =3D=3D
  When you commit a patch, please:
@@ -58, +56 @@

  =

  In addition to code changes, changes to the site documentation might be n=
ecessary. If so, please, follow the steps:
      * Install [[http://forrest.apache.org/|forrest]]
-     * Checkout site documentation: `svn co https://svn.apache.org/repos/a=
sf/hadoop/pig/site/`
+     * Checkout site documentation: `svn co https://svn.apache.org/repos/a=
sf/pig/site/`
      * Edit files in `author/src/documentation/content/xdocs`. See http://=
forrest.apache.org/ for documentation.
      * Build the site: (Make sure that JAVA_HOME pointes to java 1.5 as fo=
rrest does not work with java 1.6)
          * `cd author`
@@ -72, +70 @@

          * `svn commit -m "blah blah"`
      * Upload the changes to the documentation site: (The changes will app=
ear an 1 hour after the update.)
          * `ssh people.apache.org`
-         * `cd /www/hadoop.apache.org/pig`
+         * `cd /www/pig.apache.org`
          * `svn up`
  =

- ##=3D=3D Dialog =3D=3D
- =

- ##Committers should hang out in the #hadoop room on =

- ##irc.freenode.net for real-time discussions. However any substantive =

- ##discussion (as with any off-list project-related discussion) should =

- ##be re-iterated in Jira or on the developer list.
-=20