Return-Path: Delivered-To: apmail-incubator-pig-commits-archive@locus.apache.org Received: (qmail 28558 invoked from network); 7 Nov 2007 22:20:03 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 7 Nov 2007 22:20:03 -0000 Received: (qmail 90139 invoked by uid 500); 7 Nov 2007 22:19:44 -0000 Delivered-To: apmail-incubator-pig-commits-archive@incubator.apache.org Received: (qmail 90120 invoked by uid 500); 7 Nov 2007 22:19:44 -0000 Mailing-List: contact pig-commits-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: pig-dev@incubator.apache.org Delivered-To: mailing list pig-commits@incubator.apache.org Received: (qmail 90111 invoked by uid 99); 7 Nov 2007 22:19:44 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 07 Nov 2007 14:19:44 -0800 X-ASF-Spam-Status: No, hits=-100.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.130] (HELO eos.apache.org) (140.211.11.130) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 07 Nov 2007 22:19:55 +0000 Received: from eos.apache.org (localhost [127.0.0.1]) by eos.apache.org (Postfix) with ESMTP id 61A3B59A07 for ; Wed, 7 Nov 2007 22:19:35 +0000 (GMT) Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: Apache Wiki To: pig-commits@incubator.apache.org Date: Wed, 07 Nov 2007 22:19:35 -0000 Message-ID: <20071107221935.7859.55441@eos.apache.org> Subject: [Pig Wiki] Update of "HowToCommit" by DougCutting X-Virus-Checked: Checked by ClamAV on apache.org Dear Wiki user, You have subscribed to a wiki page or wiki category on "Pig Wiki" for change notification. The following page has been changed by DougCutting: http://wiki.apache.org/pig/HowToCommit The comment on the change is: more patch queue-related changes ------------------------------------------------------------------------------ then they can commit the patch, otherwise the patch should be cancelled with a clear explanation for why it was rejected. - The list of submitted patches is in the [https://issues.apache.org/jira/secure/IssueNavigator.jspa?mode=hide&requestId=12312187 Pig Review Queue]. This is ordered by time of last modification. Committers + The list of submitted patches is in the [https://issues.apache.org/jira/secure/IssueNavigator.jspa?mode=hide&requestId=12312187 Pig Review Queue]. This is ordered by time of last modification. Committers should scan the list from top-to-bottom, looking for patches that they feel qualified to review and possibly commit. - should scan the list from top-to-bottom, looking for patches that they feel qualified to review and possibly commit. For non-trivial changes, it is best to get another committer to - review your own patches before commit. Use "Submit Patch" like + review your own patches before commit. Set the 'Patch Available' checkbox like other contributors, and then wait for a "+1" from another committer before committing. @@ -45, +44 @@ encourage them to contribute better patches. If a committer wishes to improve an unacceptable patch, then it should first be rejected, and a new patch should be attached by the committer for review. + + Patches are rejected by editing the issue and un-setting the 'Patch Available' checkbox and adding a comment that politely details the reason(s) for rejection. (Pig needs to add its own code review checklist, but for now we are using hadoop's.)