pig-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Apache Wiki <wikidi...@apache.org>
Subject [Pig Wiki] Update of "HowToCommit" by DougCutting
Date Wed, 07 Nov 2007 22:19:35 GMT
Dear Wiki user,

You have subscribed to a wiki page or wiki category on "Pig Wiki" for change notification.

The following page has been changed by DougCutting:
http://wiki.apache.org/pig/HowToCommit

The comment on the change is:
more patch queue-related changes

------------------------------------------------------------------------------
  then they can commit the patch, otherwise the patch should be 
  cancelled with a clear explanation for why it was rejected.
  
- The list of submitted patches is in the [https://issues.apache.org/jira/secure/IssueNavigator.jspa?mode=hide&requestId=12312187
Pig Review Queue]. This is ordered by time of last modification. Committers 
+ The list of submitted patches is in the [https://issues.apache.org/jira/secure/IssueNavigator.jspa?mode=hide&requestId=12312187
Pig Review Queue]. This is ordered by time of last modification. Committers should scan the
list from top-to-bottom, looking for patches that they feel qualified to review and possibly
commit.
- should scan the list from top-to-bottom, looking for patches that they feel qualified to
review and possibly commit.
  
  For non-trivial changes, it is best to get another committer to 
- review your own patches before commit. Use "Submit Patch" like 
+ review your own patches before commit. Set the 'Patch Available' checkbox like 
  other contributors, and then wait for a "+1" from another committer 
  before committing.
  
@@ -45, +44 @@

  encourage them to contribute better patches. If a committer wishes 
  to improve an unacceptable patch, then it should first be rejected, 
  and a new patch should be attached by the committer for review.
+ 
+ Patches are rejected by editing the issue and un-setting the 'Patch Available' checkbox
and adding a comment that politely details the reason(s) for rejection.
  
  (Pig needs to add its own code review checklist, but for now we are using hadoop's.)
  

Mime
View raw message