From issues-return-7719-archive-asf-public=cust-asf.ponee.io@phoenix.apache.org Fri Jun 14 05:41:03 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id B31CB18062F for ; Fri, 14 Jun 2019 07:41:02 +0200 (CEST) Received: (qmail 4220 invoked by uid 500); 14 Jun 2019 05:41:02 -0000 Mailing-List: contact issues-help@phoenix.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@phoenix.apache.org Delivered-To: mailing list issues@phoenix.apache.org Received: (qmail 4210 invoked by uid 99); 14 Jun 2019 05:41:02 -0000 Received: from mailrelay1-us-west.apache.org (HELO mailrelay1-us-west.apache.org) (209.188.14.139) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 14 Jun 2019 05:41:02 +0000 Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 560FAE0101 for ; Fri, 14 Jun 2019 05:41:01 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id BA30A2462F for ; Fri, 14 Jun 2019 05:41:00 +0000 (UTC) Date: Fri, 14 Jun 2019 05:41:00 +0000 (UTC) From: "Hadoop QA (JIRA)" To: issues@phoenix.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (PHOENIX-5209) Cannot add non-PK column to table when the last PK column is of type VARBINARY or ARRAY MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/PHOENIX-5209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16863708#comment-16863708 ] Hadoop QA commented on PHOENIX-5209: ------------------------------------ {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12971744/PHOENIX-5209.4.x-HBase-1.5.v2.patch against 4.x-HBase-1.5 branch at commit 5bf49e62601e7d241eb0f649b78253708b1ee42d. ATTACHMENT ID: 12971744 {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:red}-1 tests included{color}. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:red}-1 release audit{color}. The applied patch generated 2 release audit warnings (more than the master's current 0 warnings). {color:green}+1 lineLengths{color}. The patch does not introduce lines longer than 100 {color:red}-1 core tests{color}. The patch failed these unit tests: ./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.index.SaltedIndexIT ./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.QueryDatabaseMetaDataIT Test results: https://builds.apache.org/job/PreCommit-PHOENIX-Build/2673//testReport/ Release audit warnings: https://builds.apache.org/job/PreCommit-PHOENIX-Build/2673//artifact/patchprocess/patchReleaseAuditWarnings.txt Console output: https://builds.apache.org/job/PreCommit-PHOENIX-Build/2673//console This message is automatically generated. > Cannot add non-PK column to table when the last PK column is of type VARBINARY or ARRAY > --------------------------------------------------------------------------------------- > > Key: PHOENIX-5209 > URL: https://issues.apache.org/jira/browse/PHOENIX-5209 > Project: Phoenix > Issue Type: Bug > Reporter: Toshihiro Suzuki > Assignee: Toshihiro Suzuki > Priority: Major > Attachments: PHOENIX-5209.4.x-HBase-1.3.v1.patch, PHOENIX-5209.4.x-HBase-1.4.v1.patch, PHOENIX-5209.4.x-HBase-1.5.v1.patch, PHOENIX-5209.4.x-HBase-1.5.v2.patch, PHOENIX-5209.master.v1.patch, PHOENIX-5209.master.v2.patch > > Time Spent: 1h 10m > Remaining Estimate: 0h > > Let's see we have the following table: > {code} > CREATE TABLE tbl (id VARBINARY PRIMARY KEY, col1 INTEGER) > {code} > The type of the primary key of this table is VARBINARY. > And when we alter this table to add a new column: > {code} > ALTER TABLE tbl ADD col2 INTEGER > {code} > we are facing the following error: > {code} > java.sql.SQLException: ERROR 1015 (42J04): Cannot add column to table when the last PK column is of type VARBINARY or ARRAY. columnName=ID > {code} > I think we should be able to do it without the above error because we don't try to add a PK column. -- This message was sent by Atlassian JIRA (v7.6.3#76005)