phoenix-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Nihal Jain (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PHOENIX-5329) Phoenix Site language section pages (Grammar,Functions & Data Types) are empty
Date Mon, 10 Jun 2019 10:34:00 GMT

    [ https://issues.apache.org/jira/browse/PHOENIX-5329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16859896#comment-16859896
] 

Nihal Jain commented on PHOENIX-5329:
-------------------------------------

Dug a little deeper and tried to build phoenix-site locally with \{{openjdk version 1.8.0_212
(}}I assume Phoenix builds site on java 8 too). I got a RunTimeException during "BUILDING
LANGUAGE REFERENCE" phase. Found we have a usage of thread.stop() in one of the testclasses.
I have attached the log.
{code:java}
src/test/org/h2/test/synth/TestCrashAPI.java:105: error: method stop in class Thread cannot
be applied to given types;
mainThread.stop(new SQLException("stop"));
{code}
Fixed it based onĀ [h2database: Do not use Thread.stop(Throwable), it does not work anyway
since Java 8|https://github.com/h2database/h2database/commit/74a94c501908a785a8032de5f0d744833ceb932f#diff-d8e4297de3fd84f11703ae619ec24268].
I am attaching[^build.log] a svn patch for it (Used "{{svn diff > filename}}"; not sure
whether it is correct way of generating patch?!)

Overall i did the following change, rest is all generated:
{code:java}
+++ phoenix-docs/src/test/org/h2/test/synth/TestCrashAPI.java	(working copy)
@@ -81,7 +81,6 @@
         TestBase.createCaller().init().test();
     }
 
-    @SuppressWarnings("deprecation")
     public void run() {
         while (--maxWait > 0) {
             try {
@@ -98,11 +97,11 @@
         if (maxWait == 0 && running) {
             objects.clear();
             if (running) {
-                println("stopping (force)...");
+                println("stopping (trying to interrupt)...");
                 for (StackTraceElement e : mainThread.getStackTrace()) {
                     System.out.println(e.toString());
                 }
-                mainThread.stop(new SQLException("stop"));
+                mainThread.interrupt();
             }
         }
     }
{code}
Tested the site by building and hosting it locally. Works good!

> Phoenix Site language section pages (Grammar,Functions & Data Types)  are empty
> -------------------------------------------------------------------------------
>
>                 Key: PHOENIX-5329
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-5329
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: Nihal Jain
>            Priority: Minor
>              Labels: documentation, website
>         Attachments: PHOENIX-5329-svn.patch, build.log
>
>
> I was looking at Apache Phoenix site and found that the following pages are empty !!
>  * [https://phoenix.apache.org/language/index.html]
>  * [https://phoenix.apache.org/language/functions.html]
>  * [https://phoenix.apache.org/language/datatypes.html]
> Just last friday it had all the content intact. Today, everything seems to be missing.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message