phoenix-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PHOENIX-5318) Slots passed to SkipScan filter is incorrect for desc primary keys that are prefixes of each other
Date Fri, 07 Jun 2019 02:08:00 GMT

    [ https://issues.apache.org/jira/browse/PHOENIX-5318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16858244#comment-16858244
] 

Hadoop QA commented on PHOENIX-5318:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12971119/PHOENIX-5318-4.x-HBase-1.3.patch
  against 4.x-HBase-1.3 branch at commit 5303d292a4c875f8ee8f484094c897f8e7595e63.
  ATTACHMENT ID: 12971119

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified
tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:red}-1 release audit{color}.  The applied patch generated 2 release audit warnings
(more than the master's current 0 warnings).

    {color:red}-1 lineLengths{color}.  The patch introduces the following lines longer than
100:
    +            // test values in the skip scan filter which are prefixes of another value,
eg 1,12 and 2,23
+            String sql = "select COL1, COL2 from " + tableName + " where COL1='1' OR COL1='2'
OR COL1='3' OR COL1='4' " +
+            Collections.sort(sorted, f.getSortOrder() == SortOrder.ASC ? KeyRange.COMPARATOR
: KeyRange.DESC_COMPARATOR);
+                    Collections.sort(sortedRange, f.getSortOrder() == SortOrder.ASC ? KeyRange.COMPARATOR
: KeyRange.DESC_COMPARATOR);
+                    //ranges.set(rowTimestampColPos, sortedRange); //TODO: do I really need
to do this?
+            result = DescVarLengthFastByteComparisons.compareTo(o1.getLowerRange(), 0, o1.getLowerRange().length,
+            result = DescVarLengthFastByteComparisons.compareTo(o1.getUpperRange(), 0, o1.getUpperRange().length,

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
     ./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.AlterTableWithViewsIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.UpgradeIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.IndexRebuildTaskIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.execute.PartialCommitIT

Test results: https://builds.apache.org/job/PreCommit-PHOENIX-Build/2635//testReport/
Release audit warnings: https://builds.apache.org/job/PreCommit-PHOENIX-Build/2635//artifact/patchprocess/patchReleaseAuditWarnings.txt
Console output: https://builds.apache.org/job/PreCommit-PHOENIX-Build/2635//console

This message is automatically generated.

> Slots passed to SkipScan filter is incorrect for desc primary keys that are prefixes
of each other
> --------------------------------------------------------------------------------------------------
>
>                 Key: PHOENIX-5318
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-5318
>             Project: Phoenix
>          Issue Type: Improvement
>    Affects Versions: 4.15.0, 5.1.0, 4.14.3
>            Reporter: Thomas D'Silva
>            Assignee: Thomas D'Silva
>            Priority: Major
>         Attachments: PHOENIX-5318-4.x-HBase-1.3.patch
>
>          Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> {code}
> CREATE VIEW IF NOT EXISTS CUSTOM_ENTITY."z01" (COL1 VARCHAR, COL2 VARCHAR, COL3 VARCHAR,
COL4 VARCHAR CONSTRAINT PK PRIMARY KEY (COL1 DESC, COL2 DESC, COL3 DESC, COL4 DESC)) AS SELECT
* FROM CUSTOM_ENTITY.CUSTOM_ENTITY_DATA_NO_ID WHERE KEY_PREFIX = 'z01'; 
>  
> UPSERT INTO CUSTOM_ENTITY."z01" (COL1, COL2, COL3, COL4) VALUES ('8', 'blah', 'blah',
'blah');
> UPSERT INTO CUSTOM_ENTITY."z01" (COL1, COL2, COL3, COL4) VALUES ('6', 'blah', 'blah',
'blah');
> UPSERT INTO CUSTOM_ENTITY."z01" (COL1, COL2, COL3, COL4) VALUES ('23', 'blah', 'blah',
'blah');
> UPSERT INTO CUSTOM_ENTITY."z01" (COL1, COL2, COL3, COL4) VALUES ('17', 'blah', 'blah',
'blah');
>  
> SELECT COL1, COL2, COL3, COL4 FROM CUSTOM_ENTITY."z01" WHERE COL4='blah' AND (COL1='1'
OR COL1='2' OR COL1='3' OR COL1='4' OR COL1='5' OR COL1='6' OR COL1='8' OR COL1='17' OR COL1='12'
OR COL1='23') AND COL3='blah'
>  
> +-------+-------+-------+-------+
> | COL1 | COL2 | COL3 | COL4 |
> +-------+-------+-------+-------+
> | 8   | blah | blah | blah |
> | 6   | blah | blah | blah |
> +-------+-------+-------+-------+
>  
> SELECT COL1, COL2, COL3, COL4 FROM CUSTOM_ENTITY."z01" WHERE COL4='blah' AND (COL1='6'OR
COL1='8' OR COL1='17' OR COL1='12' OR COL1='23') AND COL3='blah'
>  
> +-------+-------+-------+-------+
> | COL1 | COL2 | COL3 | COL4 |
> +-------+-------+-------+-------+
> | 8   | blah | blah | blah |
> | 6   | blah | blah | blah |
> | 23  | blah | blah | blah |
> | 17  | blah | blah | blah |
> +-------+-------+-------+-------
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message