phoenix-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kiran Kumar Maturi (JIRA)" <>
Subject [jira] [Commented] (PHOENIX-5269) PhoenixAccessController should use AccessChecker instead of AccessControlClient for permission checks
Date Mon, 10 Jun 2019 15:25:00 GMT


Kiran Kumar Maturi commented on PHOENIX-5269:

[~lhofhansl] [~tdsilva] sorry for the delay in the patch for the master. I am working on fixing
the following test failure when i run the PermissionsCacheIT.

BasePermissionsIT#testAutomaticGrantWithIndexAndView() . I have uploaded the master v1 patch.
java.lang.AssertionError: Expected exception was not thrown for user 'unprivilegedUser_N000007'
at org.apache.phoenix.end2end.BasePermissionsIT.verifyDenied(
at org.apache.phoenix.end2end.BasePermissionsIT.verifyDenied(
at org.apache.phoenix.end2end.BasePermissionsIT.testAutomaticGrantWithIndexAndView(
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(
at sun.reflect.DelegatingMethodAccessorImpl.invoke(
at java.lang.reflect.Method.invoke(
at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(
at org.junit.runners.model.FrameworkMethod.invokeExplosively(
at org.junit.internal.runners.statements.InvokeMethod.evaluate(
at org.junit.internal.runners.statements.RunBefores.evaluate(
at org.junit.runners.ParentRunner.runLeaf(
at org.junit.runners.BlockJUnit4ClassRunner.runChild(
at org.junit.runners.BlockJUnit4ClassRunner.runChild(
at org.junit.runners.ParentRunner$
at org.junit.runners.ParentRunner$1.schedule(
at org.junit.runners.ParentRunner.runChildren(
at org.junit.runners.ParentRunner.access$000(
at org.junit.runners.ParentRunner$2.evaluate(
at org.junit.internal.runners.statements.RunBefores.evaluate(
at org.junit.rules.ExternalResource$1.evaluate(
at org.junit.rules.RunRules.evaluate(
at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(
at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(
at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.main(


> PhoenixAccessController should use AccessChecker instead of AccessControlClient for permission
> -----------------------------------------------------------------------------------------------------
>                 Key: PHOENIX-5269
>                 URL:
>             Project: Phoenix
>          Issue Type: Bug
>    Affects Versions: 4.14.1, 4.14.2
>            Reporter: Andrew Purtell
>            Assignee: Kiran Kumar Maturi
>            Priority: Critical
>             Fix For: 4.15.0, 4.14.2
>         Attachments: PHOENIX-5269-4.14-HBase-1.4.patch, PHOENIX-5269-4.14-HBase-1.4.v1.patch,
PHOENIX-5269-4.14-HBase-1.4.v2.patch, PHOENIX-5269.4.14-HBase-1.4.v3.patch, PHOENIX-5269.4.14-HBase-1.4.v4.patch,
PHOENIX-5269.4.x-HBase-1.4.v1.patch, PHOENIX-5269.4.x-HBase-1.5.v1.patch
> PhoenixAccessController should use AccessChecker instead of AccessControlClient for permission
> In HBase, every RegionServer's AccessController maintains a local cache of permissions.
At startup time they are initialized from the ACL table. Whenever the ACL table is changed
(via grant or revoke) the AC on the ACL table "broadcasts" the change via zookeeper, which
updates the cache. This is performed and managed by TableAuthManager but is exposed as API
by AccessChecker. AccessChecker is the result of a refactor that was committed as far back
as branch-1.4 I believe.
> Phoenix implements its own access controller and is using the client API AccessControlClient
instead. AccessControlClient does not cache nor use the ZK-based cache update mechanism, because
it is designed for client side use.
> The use of AccessControlClient instead of AccessChecker is not scalable. Every permissions
check will trigger a remote RPC to the ACL table, which is generally going to be a single
region hosted on a single RegionServer. 

This message was sent by Atlassian JIRA

View raw message