phoenix-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [phoenix] priyankporwal commented on a change in pull request #517: PHOENIX-5211 Consistent Immutable Global Indexes for Non-Transactiona…
Date Wed, 12 Jun 2019 17:01:11 GMT
priyankporwal commented on a change in pull request #517: PHOENIX-5211 Consistent Immutable
Global Indexes for Non-Transactiona…
URL: https://github.com/apache/phoenix/pull/517#discussion_r293018624
 
 

 ##########
 File path: phoenix-core/src/main/java/org/apache/phoenix/execute/MutationState.java
 ##########
 @@ -24,14 +24,19 @@
 import static org.apache.phoenix.monitoring.GlobalClientMetrics.GLOBAL_MUTATION_COMMIT_TIME;
 import static org.apache.phoenix.query.QueryServices.WILDCARD_QUERY_DYNAMIC_COLS_ATTRIB;
 import static org.apache.phoenix.query.QueryServicesOptions.DEFAULT_WILDCARD_QUERY_DYNAMIC_COLS_ATTRIB;
+import static org.apache.phoenix.schema.types.PDataType.FALSE_BYTES;
+import static org.apache.phoenix.schema.types.PDataType.TRUE_BYTES;
 
 Review comment:
   I don't know much about this class yet. Bit with 492 lines of code change, I see no corresponding
test changes. Are there no existing unit-tests that need changes? If not, should we start
writing them with this change?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message