phoenix-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [phoenix] priyankporwal commented on a change in pull request #517: PHOENIX-5211 Consistent Immutable Global Indexes for Non-Transactiona…
Date Wed, 12 Jun 2019 17:01:10 GMT
priyankporwal commented on a change in pull request #517: PHOENIX-5211 Consistent Immutable
Global Indexes for Non-Transactiona…
URL: https://github.com/apache/phoenix/pull/517#discussion_r292699128
 
 

 ##########
 File path: phoenix-core/src/it/java/org/apache/phoenix/end2end/index/ImmutableIndexIT.java
 ##########
 @@ -259,7 +275,122 @@ private void assertIndexMutations(Connection conn) throws SQLException
{
                 (transactionProvider != null && 
                  transactionProvider.isUnsupported(Feature.MAINTAIN_LOCAL_INDEX_ON_SERVER)),
iterator.hasNext());
     }
-    
+
+    private void createTableAndIndexForConsistentIndex(Connection conn, String tableName,
String indexName, int numOfRowsToInsert)
+            throws Exception {
+        String ddl = "CREATE TABLE " + TABLE_NAME + TestUtil.TEST_TABLE_SCHEMA + tableDDLOptions;
+        INDEX_DDL =
 
 Review comment:
   Any risks associated with changing the static member? If there are no real benefits to
a static member, perhaps we should make this a function local variable to avoid surprises.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message