phoenix-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [phoenix] swaroopak commented on a change in pull request #514: PHOENIX-5261: Implement ALTER TABLE/VIEW ADD COLUMN CASCADE
Date Fri, 07 Jun 2019 20:00:37 GMT
swaroopak commented on a change in pull request #514: PHOENIX-5261: Implement ALTER TABLE/VIEW
ADD COLUMN CASCADE
URL: https://github.com/apache/phoenix/pull/514#discussion_r291735068
 
 

 ##########
 File path: phoenix-core/src/main/java/org/apache/phoenix/parse/AddColumnStatement.java
 ##########
 @@ -29,12 +29,16 @@
     private final List<ColumnDef> columnDefs;
     private final boolean ifNotExists;
     private final ListMultimap<String,Pair<String,Object>> props;
-    
-    protected AddColumnStatement(NamedTableNode table, PTableType tableType, List<ColumnDef>
columnDefs, boolean ifNotExists, ListMultimap<String,Pair<String,Object>> props)
{
+    private final boolean cascade;
+    private final List<NamedNode> indexes;
+
 
 Review comment:
   nit: additional line

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message