From issues-return-7287-archive-asf-public=cust-asf.ponee.io@phoenix.apache.org Fri May 31 21:29:03 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 3D6FA180627 for ; Fri, 31 May 2019 23:29:03 +0200 (CEST) Received: (qmail 63274 invoked by uid 500); 31 May 2019 21:29:02 -0000 Mailing-List: contact issues-help@phoenix.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@phoenix.apache.org Delivered-To: mailing list issues@phoenix.apache.org Received: (qmail 63253 invoked by uid 99); 31 May 2019 21:29:02 -0000 Received: from mailrelay1-us-west.apache.org (HELO mailrelay1-us-west.apache.org) (209.188.14.139) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 31 May 2019 21:29:02 +0000 Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id DA3F5E2CFE for ; Fri, 31 May 2019 21:29:01 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id AF18E245D3 for ; Fri, 31 May 2019 21:29:00 +0000 (UTC) Date: Fri, 31 May 2019 21:29:00 +0000 (UTC) From: "Lars Hofhansl (JIRA)" To: issues@phoenix.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (PHOENIX-5307) Fix HashJoinMoreIT.testBug2961 failing after PHOENIX-5262 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/PHOENIX-5307?page=3Dcom.atlassi= an.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D16= 853434#comment-16853434 ]=20 Lars Hofhansl commented on PHOENIX-5307: ---------------------------------------- Good find. Looks good to me. HashJoinMoreIT passes now. +1 =C2=A0 > Fix HashJoinMoreIT.testBug2961 failing after PHOENIX-5262 > --------------------------------------------------------- > > Key: PHOENIX-5307 > URL: https://issues.apache.org/jira/browse/PHOENIX-5307 > Project: Phoenix > Issue Type: Bug > Affects Versions: 4.15.0 > Reporter: chenglei > Assignee: chenglei > Priority: Major > Attachments: PHOENIX-5307_v1-4.x-HBase-1.4.patch > > > I noticed {{HashJoinMoreIT.testBug2961}} always failed after PHOENIX-526= 2, which is different from PHOENIX-5290: > {code} > java.lang.AssertionError > =09at org.apache.phoenix.end2end.join.HashJoinMoreIT.testBug2961(HashJoin= MoreIT.java:908) > {code} > I think this problem is caused by following line 453 modified in PHOENIX-= 5262: > {code} > 445 if ( !isFixedWidth && ( sepByte =3D=3D QueryConstants.= DESC_SEPARATOR_BYTE=20 > 446 || ( !exclusiveUpper=20 > 447 && (fieldIndex < schema.getMa= xFields() || inclusiveUpper || exclusiveLower) ) ) ) { > 448 key[offset++] =3D sepByte; > 449 // Set lastInclusiveUpperSingleKey back to false if th= is is the last pk column > 450 // as we don't want to increment the null byte in this= case > 451 // To test if this is the last pk column we need to co= nsider the span of this slot > 452 // and the field index to see if this slot considers t= he last column > 453 lastInclusiveUpperSingleKey &=3D (fieldIndex + slotSpa= n[i]) < schema.getMaxFields()-1; > 454 } > {code} > It did not consider the case that the last field is variable length and a= lso DESC, when the last field is variable length and also {{DESC}}, the tra= iliing {{0xFF}} is not removed when stored in HBASE, so for such case, we s= hould not set {{lastInclusiveUpperSingleKey}} back to false. -- This message was sent by Atlassian JIRA (v7.6.3#76005)