From issues-return-7198-archive-asf-public=cust-asf.ponee.io@phoenix.apache.org Wed May 29 03:04:04 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id D558118060F for ; Wed, 29 May 2019 05:04:03 +0200 (CEST) Received: (qmail 25246 invoked by uid 500); 29 May 2019 03:04:02 -0000 Mailing-List: contact issues-help@phoenix.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@phoenix.apache.org Delivered-To: mailing list issues@phoenix.apache.org Received: (qmail 25232 invoked by uid 99); 29 May 2019 03:04:02 -0000 Received: from mailrelay1-us-west.apache.org (HELO mailrelay1-us-west.apache.org) (209.188.14.139) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 29 May 2019 03:04:02 +0000 Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 568E9E039B for ; Wed, 29 May 2019 03:04:01 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id D8FC420FEB for ; Wed, 29 May 2019 03:04:00 +0000 (UTC) Date: Wed, 29 May 2019 03:04:00 +0000 (UTC) From: "Hadoop QA (JIRA)" To: issues@phoenix.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (PHOENIX-5305) Move expression function tests to the right folder MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/PHOENIX-5305?page=3Dcom.atlassi= an.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D16= 850324#comment-16850324 ]=20 Hadoop QA commented on PHOENIX-5305: ------------------------------------ {color:red}-1 overall{color}. Here are the results of testing the latest a= ttachment=20 http://issues.apache.org/jira/secure/attachment/12970087/PHOENIX-5305-4.x= -HBase-1.4.patch against 4.x-HBase-1.4 branch at commit d43bc67dea852b3c9d7c419680d3a1edf8= d870c7. ATTACHMENT ID: 12970087 {color:green}+1 @author{color}. The patch does not contain any @author= tags. {color:green}+1 tests included{color}. The patch appears to include 12= 0 new or modified tests. {color:green}+1 javac{color}. The applied patch does not increase the = total number of javac compiler warnings. {color:red}-1 release audit{color}. The applied patch generated 2 rele= ase audit warnings (more than the master's current 0 warnings). {color:red}-1 lineLengths{color}. The patch introduces the following l= ines longer than 100: + private static void testExpression(LiteralExpression array, Litera= lExpression element, PhoenixArray expected) + PhoenixArray result =3D (PhoenixArray) arrayAppendFunction.getData= Type().toObject(ptr, expressions.get(0).getSortOrder(), array.getMaxLength(= ), array.getScale()); + private static void test(PhoenixArray array, Object element, PDataType= arrayDataType, Integer arrMaxLen, Integer arrScale, PDataType elementDataT= ype, Integer elemMaxLen, Integer elemScale, PhoenixArray expected, SortOrde= r arraySortOrder, SortOrder elementSortOrder) throws SQLException { + arrayLiteral =3D LiteralExpression.newConstant(array, arrayDataTyp= e, arrMaxLen, arrScale, arraySortOrder, Determinism.ALWAYS); + elementLiteral =3D LiteralExpression.newConstant(element, elementD= ataType, elemMaxLen, elemScale, elementSortOrder, Determinism.ALWAYS); + test(arr, element, PDataType.fromTypeId(baseType.getSqlType() + PD= ataType.ARRAY_TYPE_BASE), null, null, baseType, null, null, expected, SortO= rder.ASC, SortOrder.ASC); + test(arr, element, PDataType.fromTypeId(baseType.getSqlType() + PD= ataType.ARRAY_TYPE_BASE), null, null, baseType, null, null, expected, SortO= rder.ASC, SortOrder.ASC); + test(arr, element, PDataType.fromTypeId(baseType.getSqlType() + PD= ataType.ARRAY_TYPE_BASE), null, null, baseType, null, null, expected, SortO= rder.ASC, SortOrder.ASC); + test(arr, element, PDataType.fromTypeId(baseType.getSqlType() + PD= ataType.ARRAY_TYPE_BASE), null, null, baseType, null, null, expected, SortO= rder.ASC, SortOrder.ASC); + Object[] o2 =3D new Object[]{new Float(2.3), new Float(7.9), new F= loat(-9.6), new Float(2.3), new Float(8.9)}; {color:red}-1 core tests{color}. The patch failed these unit tests: ./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end= .join.HashJoinMoreIT ./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.Inde= xRebuildTaskIT ./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.Upgr= adeIT ./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.Perm= issionsCacheIT Test results: https://builds.apache.org/job/PreCommit-PHOENIX-Build/2608//t= estReport/ Release audit warnings: https://builds.apache.org/job/PreCommit-PHOENIX-Bui= ld/2608//artifact/patchprocess/patchReleaseAuditWarnings.txt Console output: https://builds.apache.org/job/PreCommit-PHOENIX-Build/2608/= /console This message is automatically generated. > Move expression function tests to the right folder > -------------------------------------------------- > > Key: PHOENIX-5305 > URL: https://issues.apache.org/jira/browse/PHOENIX-5305 > Project: Phoenix > Issue Type: Improvement > Reporter: Xinyi Yan > Assignee: Xinyi Yan > Priority: Trivial > Attachments: PHOENIX-5305-4.x-HBase-1.4.patch > > > As=C2=A0[~chenglei] discovered on the other Jira, many phoenix expression= function tests are not=C2=A0under the right folder.=C2=A0Put function test= s under the package `{{org.apache.phoenix.expression.function}}=C2=A0` inst= ead of `{{org.apache.phoenix.expression}}` for better code quality. -- This message was sent by Atlassian JIRA (v7.6.3#76005)