From issues-return-7112-archive-asf-public=cust-asf.ponee.io@phoenix.apache.org Sat May 25 03:55:02 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 3FAD1180671 for ; Sat, 25 May 2019 05:55:02 +0200 (CEST) Received: (qmail 36427 invoked by uid 500); 25 May 2019 03:55:01 -0000 Mailing-List: contact issues-help@phoenix.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@phoenix.apache.org Delivered-To: mailing list issues@phoenix.apache.org Received: (qmail 36418 invoked by uid 99); 25 May 2019 03:55:01 -0000 Received: from mailrelay1-us-west.apache.org (HELO mailrelay1-us-west.apache.org) (209.188.14.139) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 25 May 2019 03:55:01 +0000 Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id E0A23E25AC for ; Sat, 25 May 2019 03:55:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 6B213256E3 for ; Sat, 25 May 2019 03:55:00 +0000 (UTC) Date: Sat, 25 May 2019 03:55:00 +0000 (UTC) From: "Hadoop QA (JIRA)" To: issues@phoenix.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (PHOENIX-5300) NoopStatisticsCollector shouldn't scan any rows. MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/PHOENIX-5300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16848027#comment-16848027 ] Hadoop QA commented on PHOENIX-5300: ------------------------------------ {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12969718/PHOENIX-5300-4.14-HBase-1.4.patch against 4.14-HBase-1.4 branch at commit 0d0efd467871582ce298d15891cce5adf50c92e4. ATTACHMENT ID: 12969718 {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:red}-1 tests included{color}. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:green}+1 lineLengths{color}. The patch does not introduce lines longer than 100 {color:red}-1 core tests{color}. The patch failed these unit tests: ./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.index.LocalMutableTxIndexIT ./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.SaltedViewIT Test results: https://builds.apache.org/job/PreCommit-PHOENIX-Build/2601//testReport/ Console output: https://builds.apache.org/job/PreCommit-PHOENIX-Build/2601//console This message is automatically generated. > NoopStatisticsCollector shouldn't scan any rows. > ------------------------------------------------ > > Key: PHOENIX-5300 > URL: https://issues.apache.org/jira/browse/PHOENIX-5300 > Project: Phoenix > Issue Type: Bug > Affects Versions: 4.14.0, 4.13.1 > Reporter: Rushabh S Shah > Assignee: Rushabh S Shah > Priority: Major > Fix For: 4.14.2 > > Attachments: PHOENIX-5300-4.14-HBase-1.4.patch, PHOENIX-5300-4.14-HBase-1.4.patch > > > Today if we disable calculation of stats via {{phoenix.stats.collection.enabled}} property, it creates {{NoopStatisticsCollector}}. If someone calls "UPDATE STATISTICS ", it will create NoopStatisticsCollector, scan the whole table and does nothing. This is fixed in 4.15 via PHOENIX-4009. If we don't want to backport PHOENIX-4009, we can fix this bug just in 4.14 -- This message was sent by Atlassian JIRA (v7.6.3#76005)