From issues-return-6769-archive-asf-public=cust-asf.ponee.io@phoenix.apache.org Fri May 10 17:55:02 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id D30FB18061A for ; Fri, 10 May 2019 19:55:01 +0200 (CEST) Received: (qmail 95463 invoked by uid 500); 10 May 2019 17:55:01 -0000 Mailing-List: contact issues-help@phoenix.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@phoenix.apache.org Delivered-To: mailing list issues@phoenix.apache.org Received: (qmail 95447 invoked by uid 99); 10 May 2019 17:55:01 -0000 Received: from mailrelay1-us-west.apache.org (HELO mailrelay1-us-west.apache.org) (209.188.14.139) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 10 May 2019 17:55:01 +0000 Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 99CCAE260C for ; Fri, 10 May 2019 17:55:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 55BC524597 for ; Fri, 10 May 2019 17:55:00 +0000 (UTC) Date: Fri, 10 May 2019 17:55:00 +0000 (UTC) From: "Andrew Purtell (JIRA)" To: issues@phoenix.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (PHOENIX-5277) Fixups for interface changes in HBase 1.5 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/PHOENIX-5277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16837486#comment-16837486 ] Andrew Purtell commented on PHOENIX-5277: ----------------------------------------- I think this is in a committable state. There are test failures once running on 1.5 but they should be followed up in another context. I would like the scope of this issue to be just about getting a buildable branch, scoped to POM changes and compile fixes for interface changes. These test failures indicate IndexedKeyValue needs work. We added some sanity checking to KeyValue. It doesn't allow you to initialize with null, empty, or otherwise invalid byte arrays. This implies IndexedKeyValue has been subtly buggy all along (IMHO). There will be quite a few follow on failures from this I think but it should not be difficult to fix. The IllegalArgumentException you see in test results like this are thrown from KeyValueUtil#checkKeyValueBytes. Sanity checks were introduced to branch-1 and 1.5 by HBASE-22034. Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.174 s <<< FAILURE! - in org.apache.hadoop.hbase.regionserver.wal.IndexedKeyValueTest testIndexedKeyValuePopulatesKVFields(org.apache.hadoop.hbase.regionserver.wal.IndexedKeyValueTest) Time elapsed: 0.128 s <<< ERROR! java.lang.IllegalArgumentException: Overflow when reading key length at position=0, KeyValueBytesHex=foo, offset=0, length=3 at org.apache.hadoop.hbase.regionserver.wal.IndexedKeyValueTest.testIndexedKeyValuePopulatesKVFields(IndexedKeyValueTest.java:42) > Fixups for interface changes in HBase 1.5 > ----------------------------------------- > > Key: PHOENIX-5277 > URL: https://issues.apache.org/jira/browse/PHOENIX-5277 > Project: Phoenix > Issue Type: Task > Reporter: Andrew Purtell > Assignee: Andrew Purtell > Priority: Major > Attachments: PHOENIX-5277-4.x.patch > > > Some minor fixups are required because of interface changes in HBase 1.5. -- This message was sent by Atlassian JIRA (v7.6.3#76005)