From issues-return-7108-archive-asf-public=cust-asf.ponee.io@phoenix.apache.org Sat May 25 02:05:03 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id C671C180671 for ; Sat, 25 May 2019 04:05:02 +0200 (CEST) Received: (qmail 86987 invoked by uid 500); 25 May 2019 02:05:02 -0000 Mailing-List: contact issues-help@phoenix.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@phoenix.apache.org Delivered-To: mailing list issues@phoenix.apache.org Received: (qmail 86970 invoked by uid 99); 25 May 2019 02:05:02 -0000 Received: from mailrelay1-us-west.apache.org (HELO mailrelay1-us-west.apache.org) (209.188.14.139) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 25 May 2019 02:05:02 +0000 Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 683CDE25AC for ; Sat, 25 May 2019 02:05:01 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id C94DC20FEB for ; Sat, 25 May 2019 02:05:00 +0000 (UTC) Date: Sat, 25 May 2019 02:05:00 +0000 (UTC) From: "Lars Hofhansl (JIRA)" To: issues@phoenix.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (PHOENIX-5112) Simplify QueryPlan selection in Phoenix. MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/PHOENIX-5112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16848011#comment-16848011 ] Lars Hofhansl commented on PHOENIX-5112: ---------------------------------------- Nope, not this change. Fails with this reverted as well... Also looking at the test, it's testing at the HBase level not getting into query planning anyway. This broke recently, though. > Simplify QueryPlan selection in Phoenix. > ---------------------------------------- > > Key: PHOENIX-5112 > URL: https://issues.apache.org/jira/browse/PHOENIX-5112 > Project: Phoenix > Issue Type: Improvement > Affects Versions: 4.15.0, 5.1.0 > Reporter: Lars Hofhansl > Assignee: Lars Hofhansl > Priority: Major > Fix For: 4.15.0, 5.1.0 > > Attachments: 5112-master.txt, 5112-master.txt > > > Brought to light in part in PHOENIX-5109, plan selection in Phoenix is too complicated with its logic spread over multiple areas. My recent changes let most index through the initial filters and next step is to put all the logic in {{QueryOptimizer.orderPlansBestToWorst}}. > One exception is plans with global indexes for queries with uncovered queries, those should still be handled in {{addPlan}}. -- This message was sent by Atlassian JIRA (v7.6.3#76005)