From issues-return-6958-archive-asf-public=cust-asf.ponee.io@phoenix.apache.org Wed May 22 19:54:43 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id D2DD1180651 for ; Wed, 22 May 2019 21:54:42 +0200 (CEST) Received: (qmail 15374 invoked by uid 500); 22 May 2019 19:54:42 -0000 Mailing-List: contact issues-help@phoenix.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@phoenix.apache.org Delivered-To: mailing list issues@phoenix.apache.org Received: (qmail 15353 invoked by uid 99); 22 May 2019 19:54:42 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 22 May 2019 19:54:42 +0000 From: GitBox To: issues@phoenix.apache.org Subject: [GitHub] [phoenix] priyankporwal commented on a change in pull request #436: PHOENIX-5118 Index Maintainer writes a wrong value to the empty column Message-ID: <155855488203.9521.5438821446495501919.gitbox@gitbox.apache.org> Date: Wed, 22 May 2019 19:54:42 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit priyankporwal commented on a change in pull request #436: PHOENIX-5118 Index Maintainer writes a wrong value to the empty column URL: https://github.com/apache/phoenix/pull/436#discussion_r286650369 ########## File path: phoenix-core/src/main/java/org/apache/phoenix/index/IndexMaintainer.java ########## @@ -964,8 +964,7 @@ public Put buildUpdateMutation(KeyValueBuilder kvBuilder, ValueGetter valueGette // add the keyvalue for the empty row put.add(kvBuilder.buildPut(new ImmutableBytesPtr(indexRowKey), this.getEmptyKeyValueFamily(), dataEmptyKeyValueRef.getQualifierWritable(), ts, - // set the value to the empty column name - dataEmptyKeyValueRef.getQualifierWritable())); + QueryConstants.EMPTY_COLUMN_VALUE_BYTES_PTR)); Review comment: nit: indentation should be consistent with line above. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services