From issues-return-6628-archive-asf-public=cust-asf.ponee.io@phoenix.apache.org Tue May 7 04:44:47 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id CF7F718060F for ; Tue, 7 May 2019 06:44:46 +0200 (CEST) Received: (qmail 72825 invoked by uid 500); 7 May 2019 04:44:46 -0000 Mailing-List: contact issues-help@phoenix.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@phoenix.apache.org Delivered-To: mailing list issues@phoenix.apache.org Received: (qmail 72815 invoked by uid 99); 7 May 2019 04:44:46 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 07 May 2019 04:44:46 +0000 From: GitBox To: issues@phoenix.apache.org Subject: [GitHub] [phoenix] swaroopak commented on a change in pull request #499: Phoenix 4703 ALTER INDEX REBUILD ALL Message-ID: <155720428098.3426.8034002299005399021.gitbox@gitbox.apache.org> Date: Tue, 07 May 2019 04:44:40 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit swaroopak commented on a change in pull request #499: Phoenix 4703 ALTER INDEX REBUILD ALL URL: https://github.com/apache/phoenix/pull/499#discussion_r281459101 ########## File path: phoenix-core/src/main/antlr3/PhoenixSQL.g ########## @@ -606,8 +606,8 @@ drop_index_node returns [DropIndexStatement ret] // Parse a alter index statement alter_index_node returns [AlterIndexStatement ret] : ALTER INDEX (IF ex=EXISTS)? i=index_name ON t=from_table_name - ((s=(USABLE | UNUSABLE | REBUILD | DISABLE | ACTIVE)) (async=ASYNC)? ((SET?)p=fam_properties)?) - {ret = factory.alterIndex(factory.namedTable(null, TableName.create(t.getSchemaName(), i.getName())), t.getTableName(), ex!=null, PIndexState.valueOf(SchemaUtil.normalizeIdentifier(s.getText())), async!=null, p); } + ((s=(USABLE | UNUSABLE | REBUILD | DISABLE | ACTIVE)) (all=ALL)? (async=ASYNC)? ((SET?)p=fam_properties)?) Review comment: Grammar seems misleading. We are expecting ALL only after REBUILD keyword. Shouldn't it be a part of REBUILD or condition, as we don't support ALL on any other keyword like USABLE | DISABLE etc? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services