From issues-return-6537-archive-asf-public=cust-asf.ponee.io@phoenix.apache.org Fri May 3 00:08:21 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id ABD2D180671 for ; Fri, 3 May 2019 02:08:20 +0200 (CEST) Received: (qmail 6407 invoked by uid 500); 3 May 2019 00:08:20 -0000 Mailing-List: contact issues-help@phoenix.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@phoenix.apache.org Delivered-To: mailing list issues@phoenix.apache.org Received: (qmail 6396 invoked by uid 99); 3 May 2019 00:08:19 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 03 May 2019 00:08:19 +0000 From: GitBox To: issues@phoenix.apache.org Subject: [GitHub] [phoenix] gokceni commented on a change in pull request #469: PHOENIX-5156 Consistent Global Indexes for Non-Transactional Tables Message-ID: <155684209926.28568.9420834232916726004.gitbox@gitbox.apache.org> Date: Fri, 03 May 2019 00:08:19 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit gokceni commented on a change in pull request #469: PHOENIX-5156 Consistent Global Indexes for Non-Transactional Tables URL: https://github.com/apache/phoenix/pull/469#discussion_r280636826 ########## File path: phoenix-core/src/main/java/org/apache/phoenix/query/QueryServicesOptions.java ########## @@ -354,6 +354,9 @@ public static final long DEFAULT_TASK_HANDLING_MAX_INTERVAL_MS = 30*60*1000; // 30 min public static final long DEFAULT_TASK_HANDLING_INITIAL_DELAY_MS = 10*1000; // 10 sec + public static final long DEFAULT_GLOBAL_INDEX_ROW_AGE_THRESHOLD_TO_DELETE_MS = 10*60*1000; /* 10 min */ + public static final int DEFAULT_GLOBAL_INDEX_REPAIR_COUNT = 100; Review comment: Isn't 100 a bit low? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services