phoenix-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lars Hofhansl (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PHOENIX-5291) Some cases where Phoenix does close scanners
Date Thu, 23 May 2019 00:59:00 GMT

    [ https://issues.apache.org/jira/browse/PHOENIX-5291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16846332#comment-16846332
] 

Lars Hofhansl commented on PHOENIX-5291:
----------------------------------------

> Why not just s.close()?

Was debating that too:

Because this deals with s == null, throwing exceptions, etc.

Before I had:
{code:java}
try {
  if (s != null) {
     s.close();
  }
} catch (IOException ignore) {
}
{code}
This seems simpler :)

I don't feel strongly, though. Can do the try/if blocks too.

> Some cases where Phoenix does close scanners
> --------------------------------------------
>
>                 Key: PHOENIX-5291
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-5291
>             Project: Phoenix
>          Issue Type: Bug
>    Affects Versions: 4.15.0, 4.14.1, 4.14.2
>            Reporter: Lars Hofhansl
>            Assignee: Lars Hofhansl
>            Priority: Critical
>         Attachments: 5291-v2.txt, 5291.txt
>
>
> With HBase 1.5 and later this is a disaster, as it causes the wrong reference counting
of HFiles in HBase, and those subsequently will *never* be removed until the region closes
and reopens for any reason.
> We found at least two cases... See comments below.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message