phoenix-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrew Purtell (JIRA)" <>
Subject [jira] [Commented] (PHOENIX-5291) Some cases where Phoenix does close scanners
Date Wed, 22 May 2019 01:20:00 GMT


Andrew Purtell commented on PHOENIX-5291:

+1 on the changes here

Hey for all of these delegate pattern cases in the Phoenix code, it is possible to add a unit
test that checks the reader reference count after the test is complete and ensures it is 0.
This would seem to be a big test coverage gap in the Phoenix unit test suite? 

> Some cases where Phoenix does close scanners
> --------------------------------------------
>                 Key: PHOENIX-5291
>                 URL:
>             Project: Phoenix
>          Issue Type: Bug
>    Affects Versions: 4.15.0, 4.14.1, 4.14.2
>            Reporter: Lars Hofhansl
>            Priority: Critical
>         Attachments: 5291.txt
> With HBase 1.5 and later this is a disaster, as it causes the wrong reference counting
of HFiles in HBase, and those subsequently will *never* be removed until the region closes
and reopens for any reason.
> We found at least two cases... See comments below.

This message was sent by Atlassian JIRA

View raw message