phoenix-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Karthik Palanisamy (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (PHOENIX-5282) "--debug" option for Sqlline
Date Thu, 16 May 2019 18:36:01 GMT

    [ https://issues.apache.org/jira/browse/PHOENIX-5282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16841627#comment-16841627
] 

Karthik Palanisamy edited comment on PHOENIX-5282 at 5/16/19 6:35 PM:
----------------------------------------------------------------------

Thank you [~jamestaylor] for looking into this.  OS sqlline does not have any log4j properties.
They seem only write Outputstream into a file with this option -log <file to write output> 
[Ref|[https://github.com/julianhyde/sqlline/blob/cb74e0b05976230a697a1e2d589eac89171f9551/src/main/java/sqlline/OutputFile.java#L24]].
However,  we already have own root logger "psql.root.logger" which defined in phoenix log4j.properties
and phoenix wrapper script sqlline.py.

IMO updating to phoenix script is ok, Instead.  But I can update in OS Sqlline if you would. 

I also updated a new patch here with the change of argument name to "-debug". 

"-d" is meant to Driver in sqlline.

 


was (Author: kpalanisamy):
Thank you [~jamestaylor] for looking into this.  OS sqlline does not have any log4j properties.
They seem only write Outputstream into a file with this option -log <file to write output> 
[link|[https://github.com/julianhyde/sqlline/blob/cb74e0b05976230a697a1e2d589eac89171f9551/src/main/java/sqlline/OutputFile.java#L24]].
However,  we already have own root logger "psql.root.logger" which defined in phoenix log4j.properties
and phoenix wrapper script sqlline.py.

IMO updating to phoenix script is ok, Instead.  But I can update in OS Sqlline if you would. 

I also updated a new patch here with the change of argument name to "-debug". 

"-d" is meant to Driver in sqlline.

 

> "--debug" option for Sqlline
> ----------------------------
>
>                 Key: PHOENIX-5282
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-5282
>             Project: Phoenix
>          Issue Type: Improvement
>    Affects Versions: 4.7.0, 4.14.0, 5.0.0
>            Reporter: Karthik Palanisamy
>            Priority: Minor
>         Attachments: PHOENIX-5282.master.v1.patch, PHOENIX-5282.master.v2.patch
>
>
> This provides a simple flag "–debug" or "-d" for enabling client-side debug log in Sqlline/Sqlline-thin
console.  No changes required from log4j property.
> {code:java}
> sqlline.py --help
> usage: sqlline.py [-h] [-v VERBOSE] [-c COLOR] [-fc FASTCONNECT] [-d]
> [zookeepers] [sqlfile]
> ...
> optional arguments:
> ...
> -d, --debug           Enable debug logger.{code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message