phoenix-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrew Purtell (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PHOENIX-5277) Fixups for interface changes in HBase 1.5
Date Fri, 10 May 2019 17:55:00 GMT

    [ https://issues.apache.org/jira/browse/PHOENIX-5277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16837486#comment-16837486
] 

Andrew Purtell commented on PHOENIX-5277:
-----------------------------------------

I think this is in a committable state. There are test failures once running on 1.5 but they
should be followed up in another context. I would like the scope of this issue to be just
about getting a buildable branch, scoped to POM changes and compile fixes for interface changes.


These test failures indicate IndexedKeyValue needs work. We added some sanity checking to
KeyValue. It doesn't allow you to initialize with null, empty, or otherwise invalid byte arrays.
This implies IndexedKeyValue has been subtly buggy all along (IMHO). There will be quite a
few follow on failures from this I think but it should not be difficult to fix.

The IllegalArgumentException you see in test results like this are thrown from KeyValueUtil#checkKeyValueBytes.
Sanity checks were introduced to branch-1 and 1.5 by HBASE-22034. 

Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.174 s <<< FAILURE!
- in org.apache.hadoop.hbase.regionserver.wal.IndexedKeyValueTest
testIndexedKeyValuePopulatesKVFields(org.apache.hadoop.hbase.regionserver.wal.IndexedKeyValueTest)
 Time elapsed: 0.128 s  <<< ERROR!
java.lang.IllegalArgumentException: Overflow when reading key length at position=0, KeyValueBytesHex=foo,
offset=0, length=3
        at org.apache.hadoop.hbase.regionserver.wal.IndexedKeyValueTest.testIndexedKeyValuePopulatesKVFields(IndexedKeyValueTest.java:42)


> Fixups for interface changes in HBase 1.5
> -----------------------------------------
>
>                 Key: PHOENIX-5277
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-5277
>             Project: Phoenix
>          Issue Type: Task
>            Reporter: Andrew Purtell
>            Assignee: Andrew Purtell
>            Priority: Major
>         Attachments: PHOENIX-5277-4.x.patch
>
>
> Some minor fixups are required because of interface changes in HBase 1.5.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message