phoenix-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <>
Subject [jira] [Commented] (PHOENIX-5273) Singleton ConnectionQueryServices for UpdateCacheAcrossDifferentClientsIT
Date Wed, 08 May 2019 00:51:00 GMT


Hadoop QA commented on PHOENIX-5273:

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment
  against 4.x-HBase-1.3 branch at commit d9057de0e5ec7f1b89b6586f6c03f73163fd01ee.
  ATTACHMENT ID: 12968110

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+0 tests included{color}.  The patch appears to be a documentation, build,
                        or dev patch that doesn't require tests.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:red}-1 release audit{color}.  The applied patch generated 6 release audit warnings
(more than the master's current 0 warnings).

    {color:red}-1 lineLengths{color}.  The patch introduces the following lines longer than
    +        conf.set(QueryServices.EXTRA_JDBC_ARGUMENTS_ATTRIB, QueryServicesOptions.DEFAULT_EXTRA_JDBC_ARGUMENTS);
+                fail("Should throw org.apache.hadoop.hbase.TableNotFoundException since the
latest metadata " +
+                    if(org.apache.hadoop.hbase.TableNotFoundException.class.equals(throwable.getClass()))
+                assertTrue("Should throw org.apache.hadoop.hbase.TableNotFoundException since
the latest" +

     {color:red}-1 core tests{color}.  The patch failed these unit tests:

Test results:
Release audit warnings:
Console output:

This message is automatically generated.

> Singleton ConnectionQueryServices for UpdateCacheAcrossDifferentClientsIT
> -------------------------------------------------------------------------
>                 Key: PHOENIX-5273
>                 URL:
>             Project: Phoenix
>          Issue Type: Bug
>    Affects Versions: 4.14.1
>            Reporter: Daniel Wong
>            Assignee: Thomas D'Silva
>            Priority: Minor
>             Fix For: 4.15.0
>         Attachments: PHOENIX-5273-4.x-HBase-1.3-v2.patch, PHOENIX-5273-4.x-HBase-1.3.patch
> While I was implementing my pluggable stats cache and related work I found that the IT,
UpdateCacheAcrossDifferentClientsIT assumes it uses 2 different ConnectionQueryServices. 
When I was debugging it however I saw that it still had the test properties in the JDBC url
which caused it to use the PhoenixTestDriver which has a Singleton for ConnectionQueryServices. 
When I corrected this error one of the tests started failing.

This message was sent by Atlassian JIRA

View raw message