phoenix-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Daniel Wong (JIRA)" <>
Subject [jira] [Commented] (PHOENIX-5273) Singleton ConnectionQueryServices for UpdateCacheAcrossDifferentClientsIT
Date Tue, 07 May 2019 22:10:00 GMT


Daniel Wong commented on PHOENIX-5273:

Patch looks fine to me.  One nit: We should ensure the exception is coming from the
not from the createStatement as we discussed offline.

> Singleton ConnectionQueryServices for UpdateCacheAcrossDifferentClientsIT
> -------------------------------------------------------------------------
>                 Key: PHOENIX-5273
>                 URL:
>             Project: Phoenix
>          Issue Type: Bug
>    Affects Versions: 4.14.1
>            Reporter: Daniel Wong
>            Assignee: Thomas D'Silva
>            Priority: Minor
>             Fix For: 4.15.0
>         Attachments: PHOENIX-5273-4.x-HBase-1.3.patch
> While I was implementing my pluggable stats cache and related work I found that the IT,
UpdateCacheAcrossDifferentClientsIT assumes it uses 2 different ConnectionQueryServices. 
When I was debugging it however I saw that it still had the test properties in the JDBC url
which caused it to use the PhoenixTestDriver which has a Singleton for ConnectionQueryServices. 
When I corrected this error one of the tests started failing.

This message was sent by Atlassian JIRA

View raw message