phoenix-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PHOENIX-5272) Support ALTER INDEX REBUILD ALL ASYNC to fully rebuild global indexes async
Date Wed, 29 May 2019 22:11:00 GMT

    [ https://issues.apache.org/jira/browse/PHOENIX-5272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16851348#comment-16851348
] 

Hadoop QA commented on PHOENIX-5272:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12970230/PHOENIX-5272.patch
  against master branch at commit 1acc43d2ca80fd4a49da48c658425990762d9e1b.
  ATTACHMENT ID: 12970230

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 4 new or modified
tests.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:red}-1 release audit{color}.  The applied patch generated 2 release audit warnings
(more than the master's current 0 warnings).

    {color:red}-1 lineLengths{color}.  The patch introduces the following lines longer than
100:
    +    public static void waitForTaskState(Connection conn, PTable.TaskType taskType, PTable.TaskStatus
expectedTaskStatus) throws InterruptedException,
+            PreparedStatement upsertStmt = conn.prepareStatement("UPSERT INTO " + testTable
+ " VALUES(?, ?)");
+            conn.createStatement().execute("DELETE " + " FROM " + PhoenixDatabaseMetaData.SYSTEM_TASK_NAME);
+            Table indexTable = conn.unwrap(PhoenixConnection.class).getQueryServices().getTable(Bytes.toBytes(indexName));
+      ((s=(USABLE | UNUSABLE | REBUILD (isRebuildAll=ALL)? | DISABLE | ACTIVE)) (async=ASYNC)?
((SET?)p=fam_properties)?)
+      {ret = factory.alterIndex(factory.namedTable(null, TableName.create(t.getSchemaName(),
i.getName())), t.getTableName(), ex!=null, PIndexState.valueOf(SchemaUtil.normalizeIdentifier(s.getText())),
isRebuildAll!=null, async!=null, p); }
+                            false, taskRecord.getTenantId(), shouldDisable, rebuildAll, runForeground);
+        public ExecutableAlterIndexStatement(NamedTableNode indexTableNode, String dataTableName,
boolean ifExists, PIndexState state, boolean isRebuildAll, boolean async, ListMultimap<String,Pair<String,Object>>
props) {
+        public AlterIndexStatement alterIndex(NamedTableNode indexTableNode, String dataTableName,
boolean ifExists, PIndexState state, boolean isRebuildAll, boolean async, ListMultimap<String,Pair<String,Object>>
props) {
+            return new ExecutableAlterIndexStatement(indexTableNode, dataTableName, ifExists,
state, isRebuildAll, async, props);

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
     ./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.join.HashJoinMoreIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.UpgradeIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.index.MutableIndexSplitForwardScanIT

Test results: https://builds.apache.org/job/PreCommit-PHOENIX-Build/2613//testReport/
Release audit warnings: https://builds.apache.org/job/PreCommit-PHOENIX-Build/2613//artifact/patchprocess/patchReleaseAuditWarnings.txt
Console output: https://builds.apache.org/job/PreCommit-PHOENIX-Build/2613//console

This message is automatically generated.

> Support ALTER INDEX REBUILD ALL ASYNC to fully rebuild global indexes async
> ---------------------------------------------------------------------------
>
>                 Key: PHOENIX-5272
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-5272
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: Gokcen Iskender
>            Assignee: Gokcen Iskender
>            Priority: Major
>             Fix For: 4.15.0, 5.1.0
>
>         Attachments: PHOENIX-5272-4.x.patch, PHOENIX-5272.patch
>
>
> This Jira is part of PHOENIX-4703. On 4703, a flag to IndexTool is added so that we can
delete all global indexes before rebuilding. This Jira is concentrated on ALTER INDEX REBUILD
ALL sql syntax.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message