phoenix-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PHOENIX-5269) PhoenixAccessController should use AccessChecker instead of AccessControlClient for permission checks
Date Wed, 08 May 2019 17:18:00 GMT

    [ https://issues.apache.org/jira/browse/PHOENIX-5269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16835768#comment-16835768
] 

Hadoop QA commented on PHOENIX-5269:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12968209/PHOENIX-5269-4.14-HBase-1.4.patch
  against 4.14-HBase-1.4 branch at commit d9057de0e5ec7f1b89b6586f6c03f73163fd01ee.
  ATTACHMENT ID: 12968209

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified
tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:red}-1 javac{color}.  The patch appears to cause mvn compile goal to fail .

    Compilation errors resume:
    [ERROR] COMPILATION ERROR : 
[ERROR] /home/jenkins/jenkins-slave/workspace/PreCommit-PHOENIX-Build/phoenix-core/src/main/java/org/apache/phoenix/coprocessor/PhoenixAccessController.java:[55,47]
cannot find symbol
[ERROR] /home/jenkins/jenkins-slave/workspace/PreCommit-PHOENIX-Build/phoenix-core/src/main/java/org/apache/phoenix/coprocessor/PhoenixAccessController.java:[82,13]
cannot find symbol
[ERROR] /home/jenkins/jenkins-slave/workspace/PreCommit-PHOENIX-Build/phoenix-core/src/main/java/org/apache/phoenix/coprocessor/PhoenixAccessController.java:[146,29]
cannot find symbol
[ERROR] /home/jenkins/jenkins-slave/workspace/PreCommit-PHOENIX-Build/phoenix-core/src/main/java/org/apache/phoenix/coprocessor/PhoenixAccessController.java:[255,22]
cannot find symbol
[ERROR] /home/jenkins/jenkins-slave/workspace/PreCommit-PHOENIX-Build/phoenix-core/src/main/java/org/apache/phoenix/coprocessor/PhoenixAccessController.java:[255,57]
cannot find symbol
[ERROR] /home/jenkins/jenkins-slave/workspace/PreCommit-PHOENIX-Build/phoenix-core/src/main/java/org/apache/phoenix/coprocessor/PhoenixAccessController.java:[272,22]
cannot find symbol
[ERROR] /home/jenkins/jenkins-slave/workspace/PreCommit-PHOENIX-Build/phoenix-core/src/main/java/org/apache/phoenix/coprocessor/PhoenixAccessController.java:[272,57]
cannot find symbol
[ERROR] /home/jenkins/jenkins-slave/workspace/PreCommit-PHOENIX-Build/phoenix-core/src/main/java/org/apache/phoenix/coprocessor/PhoenixAccessController.java:[433,22]
cannot find symbol
[ERROR] /home/jenkins/jenkins-slave/workspace/PreCommit-PHOENIX-Build/phoenix-core/src/main/java/org/apache/phoenix/coprocessor/PhoenixAccessController.java:[433,63]
cannot find symbol
[ERROR] /home/jenkins/jenkins-slave/workspace/PreCommit-PHOENIX-Build/phoenix-core/src/main/java/org/apache/phoenix/coprocessor/PhoenixAccessController.java:[482,114]
cannot find symbol
[ERROR] /home/jenkins/jenkins-slave/workspace/PreCommit-PHOENIX-Build/phoenix-core/src/main/java/org/apache/phoenix/coprocessor/PhoenixAccessController.java:[463,23]
cannot find symbol
[ERROR] /home/jenkins/jenkins-slave/workspace/PreCommit-PHOENIX-Build/phoenix-core/src/main/java/org/apache/phoenix/coprocessor/PhoenixAccessController.java:[463,64]
cannot find symbol
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.0:compile
(default-compile) on project phoenix-core: Compilation failure: Compilation failure: 
[ERROR] /home/jenkins/jenkins-slave/workspace/PreCommit-PHOENIX-Build/phoenix-core/src/main/java/org/apache/phoenix/coprocessor/PhoenixAccessController.java:[55,47]
cannot find symbol
[ERROR]   symbol:   class AccessChecker
[ERROR]   location: package org.apache.hadoop.hbase.security.access
[ERROR] /home/jenkins/jenkins-slave/workspace/PreCommit-PHOENIX-Build/phoenix-core/src/main/java/org/apache/phoenix/coprocessor/PhoenixAccessController.java:[82,13]
cannot find symbol
[ERROR]   symbol:   class AccessChecker
[ERROR]   location: class org.apache.phoenix.coprocessor.PhoenixAccessController
[ERROR] /home/jenkins/jenkins-slave/workspace/PreCommit-PHOENIX-Build/phoenix-core/src/main/java/org/apache/phoenix/coprocessor/PhoenixAccessController.java:[146,29]
cannot find symbol
[ERROR]   symbol:   class AccessChecker
[ERROR]   location: class org.apache.phoenix.coprocessor.PhoenixAccessController
[ERROR] /home/jenkins/jenkins-slave/workspace/PreCommit-PHOENIX-Build/phoenix-core/src/main/java/org/apache/phoenix/coprocessor/PhoenixAccessController.java:[255,22]
cannot find symbol
[ERROR]   symbol: class Connection
[ERROR] /home/jenkins/jenkins-slave/workspace/PreCommit-PHOENIX-Build/phoenix-core/src/main/java/org/apache/phoenix/coprocessor/PhoenixAccessController.java:[255,57]
cannot find symbol
[ERROR]   symbol:   method createConnection(org.apache.hadoop.conf.Configuration)
[ERROR]   location: class org.apache.phoenix.util.ServerUtil.ConnectionFactory
[ERROR] /home/jenkins/jenkins-slave/workspace/PreCommit-PHOENIX-Build/phoenix-core/src/main/java/org/apache/phoenix/coprocessor/PhoenixAccessController.java:[272,22]
cannot find symbol
[ERROR]   symbol: class Connection
[ERROR] /home/jenkins/jenkins-slave/workspace/PreCommit-PHOENIX-Build/phoenix-core/src/main/java/org/apache/phoenix/coprocessor/PhoenixAccessController.java:[272,57]
cannot find symbol
[ERROR]   symbol:   method createConnection(org.apache.hadoop.conf.Configuration)
[ERROR]   location: class org.apache.phoenix.util.ServerUtil.ConnectionFactory
[ERROR] /home/jenkins/jenkins-slave/workspace/PreCommit-PHOENIX-Build/phoenix-core/src/main/java/org/apache/phoenix/coprocessor/PhoenixAccessController.java:[433,22]
cannot find symbol
[ERROR]   symbol: class Connection
[ERROR] /home/jenkins/jenkins-slave/workspace/PreCommit-PHOENIX-Build/phoenix-core/src/main/java/org/apache/phoenix/coprocessor/PhoenixAccessController.java:[433,63]
cannot find symbol
[ERROR]   symbol:   method createConnection(org.apache.hadoop.conf.Configuration)
[ERROR]   location: class org.apache.phoenix.util.ServerUtil.ConnectionFactory
[ERROR] /home/jenkins/jenkins-slave/workspace/PreCommit-PHOENIX-Build/phoenix-core/src/main/java/org/apache/phoenix/coprocessor/PhoenixAccessController.java:[482,114]
cannot find symbol
[ERROR]   symbol: class Connection
[ERROR] /home/jenkins/jenkins-slave/workspace/PreCommit-PHOENIX-Build/phoenix-core/src/main/java/org/apache/phoenix/coprocessor/PhoenixAccessController.java:[463,23]
cannot find symbol
[ERROR]   symbol: class Connection
[ERROR] /home/jenkins/jenkins-slave/workspace/PreCommit-PHOENIX-Build/phoenix-core/src/main/java/org/apache/phoenix/coprocessor/PhoenixAccessController.java:[463,64]
cannot find symbol
[ERROR]   symbol:   method createConnection(org.apache.hadoop.conf.Configuration)
[ERROR]   location: class org.apache.phoenix.util.ServerUtil.ConnectionFactory
[ERROR] -> [Help 1]
[ERROR] 
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR] 
[ERROR] For more information about the errors and possible solutions, please read the following
articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
[ERROR] 
[ERROR] After correcting the problems, you can resume the build with the command
[ERROR]   mvn <goals> -rf :phoenix-core
    

Console output: https://builds.apache.org/job/PreCommit-PHOENIX-Build/2570//console

This message is automatically generated.

> PhoenixAccessController should use AccessChecker instead of AccessControlClient for permission
checks
> -----------------------------------------------------------------------------------------------------
>
>                 Key: PHOENIX-5269
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-5269
>             Project: Phoenix
>          Issue Type: Bug
>    Affects Versions: 4.14.1, 4.14.2
>            Reporter: Andrew Purtell
>            Assignee: Kiran Kumar Maturi
>            Priority: Critical
>         Attachments: PHOENIX-5269-4.14-HBase-1.4.patch
>
>
> PhoenixAccessController should use AccessChecker instead of AccessControlClient for permission
checks. 
> In HBase, every RegionServer's AccessController maintains a local cache of permissions.
At startup time they are initialized from the ACL table. Whenever the ACL table is changed
(via grant or revoke) the AC on the ACL table "broadcasts" the change via zookeeper, which
updates the cache. This is performed and managed by TableAuthManager but is exposed as API
by AccessChecker. AccessChecker is the result of a refactor that was committed as far back
as branch-1.4 I believe.
> Phoenix implements its own access controller and is using the client API AccessControlClient
instead. AccessControlClient does not cache nor use the ZK-based cache update mechanism, because
it is designed for client side use.
> The use of AccessControlClient instead of AccessChecker is not scalable. Every permissions
check will trigger a remote RPC to the ACL table, which is generally going to be a single
region hosted on a single RegionServer. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message