phoenix-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PHOENIX-5264) Implement the toString method of EncodedQualifiersColumnProjectionFilter
Date Fri, 03 May 2019 20:52:00 GMT

    [ https://issues.apache.org/jira/browse/PHOENIX-5264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16832814#comment-16832814
] 

Hadoop QA commented on PHOENIX-5264:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12967798/PHOENIX-5264.master.001.patch
  against master branch at commit 4eec41f3f2b04865b6d59ebd3fbd3aa1e0a0fd80.
  ATTACHMENT ID: 12967798

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 3 new or modified
tests.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:red}-1 release audit{color}.  The applied patch generated 6 release audit warnings
(more than the master's current 0 warnings).

    {color:green}+1 lineLengths{color}.  The patch does not introduce lines longer than 100

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
     ./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.IndexRebuildTaskIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.join.HashJoinMoreIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.index.MutableIndexSplitForwardScanIT

Test results: https://builds.apache.org/job/PreCommit-PHOENIX-Build/2552//testReport/
Release audit warnings: https://builds.apache.org/job/PreCommit-PHOENIX-Build/2552//artifact/patchprocess/patchReleaseAuditWarnings.txt
Console output: https://builds.apache.org/job/PreCommit-PHOENIX-Build/2552//console

This message is automatically generated.

> Implement the toString method of EncodedQualifiersColumnProjectionFilter  
> --------------------------------------------------------------------------
>
>                 Key: PHOENIX-5264
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-5264
>             Project: Phoenix
>          Issue Type: Bug
>    Affects Versions: 4.14.0, 5.0.0
>            Reporter: Kadir OZDEMIR
>            Assignee: Priyank Porwal
>            Priority: Minor
>             Fix For: 4.14.0, 5.0.0
>
>         Attachments: PHOENIX-5264.master.001.patch
>
>          Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> The current implementation of the toString method of EncodedQualifiersColumnProjectionFilter
returns an empty string. Having a proper implementation helps during debugging. Please see
some other Filter classes, to get an idea on how to implement this, e.g., SingleColumnValueFilter, SkipScanFilter,
and PrefixFilter.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message