phoenix-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vincent Poon (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PHOENIX-5231) Configurable Stats Cache
Date Thu, 30 May 2019 21:10:00 GMT

    [ https://issues.apache.org/jira/browse/PHOENIX-5231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16852366#comment-16852366
] 

Vincent Poon commented on PHOENIX-5231:
---------------------------------------

[~lhofhansl] [~dbwong] We need to at a minimum change this line in GuidePostsCacheProvider:
{{Class clazz = ClassLoader.getSystemClassLoader().loadClass(classString);}}
to instead use
{{Class class = Class.forName(classString);}}

The latter uses the current thread's class loader, which is what you typically want anyways.
 It's what we use everywhere else we need to dynamically load classes.

As for the Services framework, we need a small patch to the Presto client.  That is unrelated
to the change here, and probably a good thing to have anyways.

So if we do the above fix, and put the small patch into Presto, things should work.

> Configurable Stats Cache
> ------------------------
>
>                 Key: PHOENIX-5231
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-5231
>             Project: Phoenix
>          Issue Type: Test
>            Reporter: Daniel Wong
>            Assignee: Daniel Wong
>            Priority: Major
>             Fix For: 4.15.0, 5.1.0
>
>         Attachments: 5231-quickfix-v2.txt, 5231-quickfix.txt, 5231-services-fix.patch,
PHOENIX-5231.4.x-HBase-1.3.patch, PHOENIX-5231.4.x-HBase-1.3.v2.patch, PHOENIX-5231.4.x-HBase-1.3.v3.patch,
PHOENIX-5231.master.v3.patch, PHOENIX-5231.master.v4.patch
>
>          Time Spent: 8h 40m
>  Remaining Estimate: 0h
>
> Currently, the phoenix stats cache is per ConnectionQuerySerivce/ConnectionProfile, which
leads to duplicated cached entry (the guideposts) and waste resources if these separate connections
are querying the same underlying table. It would be good to be able to provide a configurable
stats cache as control the cache level so it could be per JVM.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message