phoenix-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vincent Poon (JIRA)" <>
Subject [jira] [Commented] (PHOENIX-5231) Configurable Stats Cache
Date Tue, 28 May 2019 22:10:00 GMT


Vincent Poon commented on PHOENIX-5231:

[~lhofhansl][~dbwong][~karanmehta93] As Lars's patch alludes to, this is an issue with the
phoenix-core pom, not phoenix-client.  If you do "jar -tf" on the phoenix-core jar, you'll
see it's not there either.
Normally, you just drop in your files in src/main/resources/META-INF/services and Maven automatically
includes it.  The problem is someone did an override of the normal resource inclusion, which
is what Lars's patch modifies.
I've uploaded an alternative fix, which is to not have this special override at all, and just
move java.sql.Driver to where it should be in src/main/resources/META-INF/services

Phoenix-client then automatically bundles it since it has a ServicesResourceTransformer defined.

Only open question I have is how was this working previously on your local, [~dbwong] and
[~karanmehta93].  Maybe you have an uncommitted file somewhere? [^5231-services-fix.patch]

> Configurable Stats Cache
> ------------------------
>                 Key: PHOENIX-5231
>                 URL:
>             Project: Phoenix
>          Issue Type: Test
>            Reporter: Daniel Wong
>            Assignee: Daniel Wong
>            Priority: Major
>             Fix For: 4.15.0, 5.1.0
>         Attachments: 5231-quickfix-v2.txt, 5231-quickfix.txt, 5231-services-fix.patch,
PHOENIX-5231.4.x-HBase-1.3.patch, PHOENIX-5231.4.x-HBase-1.3.v2.patch, PHOENIX-5231.4.x-HBase-1.3.v3.patch,
PHOENIX-5231.master.v3.patch, PHOENIX-5231.master.v4.patch
>          Time Spent: 8h 40m
>  Remaining Estimate: 0h
> Currently, the phoenix stats cache is per ConnectionQuerySerivce/ConnectionProfile, which
leads to duplicated cached entry (the guideposts) and waste resources if these separate connections
are querying the same underlying table. It would be good to be able to provide a configurable
stats cache as control the cache level so it could be per JVM.

This message was sent by Atlassian JIRA

View raw message