phoenix-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [phoenix] priyankporwal commented on a change in pull request #499: Phoenix-5272 ALTER INDEX REBUILD ALL
Date Wed, 29 May 2019 22:12:08 GMT
priyankporwal commented on a change in pull request #499: Phoenix-5272 ALTER INDEX REBUILD
ALL 
URL: https://github.com/apache/phoenix/pull/499#discussion_r288789575
 
 

 ##########
 File path: phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java
 ##########
 @@ -4362,18 +4365,40 @@ public MutationState alterIndex(AlterIndexStatement statement) throws
SQLExcepti
                     // Set so that we get the table below with the potentially modified rowKeyOrderOptimizable
flag set
                     indexRef.setTable(result.getTable());
                     if (newIndexState == PIndexState.BUILDING && isAsync) {
-                        try {
-                            tableUpsert = connection.prepareStatement(UPDATE_INDEX_REBUILD_ASYNC_STATE);
-                            tableUpsert.setString(1,
-                                    connection.getTenantId() == null ? null : connection.getTenantId().getString());
-                            tableUpsert.setString(2, schemaName);
-                            tableUpsert.setString(3, indexName);
-                            tableUpsert.setLong(4, result.getTable().getTimeStamp());
-                            tableUpsert.execute();
-                            connection.commit();
-                        } finally {
-                            if (tableUpsert != null) {
-                                tableUpsert.close();
+                        if (isRebuildAll) {
+                            List<Task.TaskRecord> tasks = Task.queryTaskTable(connection,
schemaName, tableName, PTable.TaskType.INDEX_REBUILD,
 
 Review comment:
   @gokceni My question was about multiple indexes on the same data-table. Since you say that
the tableName is data-table, does this check prevent running ALTER-INDEX REBUILD ALL on two
or more of indexes on the same data-table?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message