phoenix-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [phoenix] gokceni commented on a change in pull request #499: Phoenix-5272 ALTER INDEX REBUILD ALL
Date Thu, 23 May 2019 17:45:46 GMT
gokceni commented on a change in pull request #499: Phoenix-5272 ALTER INDEX REBUILD ALL 
URL: https://github.com/apache/phoenix/pull/499#discussion_r287060396
 
 

 ##########
 File path: phoenix-core/src/main/java/org/apache/phoenix/jdbc/PhoenixStatement.java
 ##########
 @@ -1248,8 +1248,8 @@ public MutationState execute() throws SQLException {
 
     private static class ExecutableAlterIndexStatement extends AlterIndexStatement implements
CompilableStatement {
 
-        public ExecutableAlterIndexStatement(NamedTableNode indexTableNode, String dataTableName,
boolean ifExists, PIndexState state, boolean async, ListMultimap<String,Pair<String,Object>>
props) {
-            super(indexTableNode, dataTableName, ifExists, state, async, props);
+        public ExecutableAlterIndexStatement(NamedTableNode indexTableNode, String dataTableName,
boolean ifExists, PIndexState state, boolean isAll, boolean async, ListMultimap<String,Pair<String,Object>>
props) {
+            super(indexTableNode, dataTableName, ifExists, state, isAll, async, props);
 
 Review comment:
   Also, I prefer isRebuildAll because this is just returning the boolean parameter. However,
rebuildAll suggests a function name where you actually rebuild the index. It is harder to
read the code that way.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message