phoenix-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [phoenix] priyankporwal commented on a change in pull request #436: PHOENIX-5118 Index Maintainer writes a wrong value to the empty column
Date Wed, 22 May 2019 19:54:42 GMT
priyankporwal commented on a change in pull request #436: PHOENIX-5118 Index Maintainer writes
a wrong value to the empty column
URL: https://github.com/apache/phoenix/pull/436#discussion_r286651692
 
 

 ##########
 File path: phoenix-core/src/main/java/org/apache/phoenix/index/IndexMaintainer.java
 ##########
 @@ -964,8 +964,7 @@ public Put buildUpdateMutation(KeyValueBuilder kvBuilder, ValueGetter
valueGette
             // add the keyvalue for the empty row
             put.add(kvBuilder.buildPut(new ImmutableBytesPtr(indexRowKey),
                 this.getEmptyKeyValueFamily(), dataEmptyKeyValueRef.getQualifierWritable(),
ts,
-                // set the value to the empty column name
 
 Review comment:
   Are there any tests to validate this empty column value? If not, perhaps we should add
one. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message