phoenix-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [phoenix] priyankporwal commented on a change in pull request #499: Phoenix-5272 ALTER INDEX REBUILD ALL
Date Mon, 20 May 2019 18:30:27 GMT
priyankporwal commented on a change in pull request #499: Phoenix-5272 ALTER INDEX REBUILD
ALL 
URL: https://github.com/apache/phoenix/pull/499#discussion_r285707364
 
 

 ##########
 File path: phoenix-core/src/main/java/org/apache/phoenix/parse/AlterIndexStatement.java
 ##########
 @@ -65,6 +67,10 @@ public boolean isAsync() {
         return async;
     }
 
+    public boolean IsRebuildAll() {
 
 Review comment:
   Nit: Function names are better started with verbs and Rebuild fits fine. Suggest rename
to RebuildAll() .. and make the member variable rebuildAll

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message