phoenix-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [phoenix] priyankporwal commented on a change in pull request #499: Phoenix-5272 ALTER INDEX REBUILD ALL
Date Mon, 20 May 2019 18:30:27 GMT
priyankporwal commented on a change in pull request #499: Phoenix-5272 ALTER INDEX REBUILD
ALL 
URL: https://github.com/apache/phoenix/pull/499#discussion_r285705360
 
 

 ##########
 File path: phoenix-core/src/main/java/org/apache/phoenix/coprocessor/tasks/IndexRebuildTask.java
 ##########
 @@ -56,26 +59,34 @@
             }
 
             boolean shouldDisable = false;
-            if (jsonObject.has("DisableBefore")) {
-                String disableBefore = jsonObject.get("DisableBefore").toString();
+            if (jsonObject.has(DISABLE_BEFORE)) {
+                String disableBefore = jsonObject.get(DISABLE_BEFORE).toString();
                 if (!Strings.isNullOrEmpty(disableBefore)) {
                     shouldDisable = Boolean.valueOf(disableBefore);
                 }
             }
 
+            boolean deleteBeforeRebuildAll = false;
 
 Review comment:
   Can we simply call this variable 'rebuildAll'? It's value seems to correspond to 'REBUILD
ALL'

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message