phoenix-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [phoenix] priyankporwal commented on a change in pull request #499: Phoenix-5272 ALTER INDEX REBUILD ALL
Date Mon, 20 May 2019 18:30:27 GMT
priyankporwal commented on a change in pull request #499: Phoenix-5272 ALTER INDEX REBUILD
ALL 
URL: https://github.com/apache/phoenix/pull/499#discussion_r285706786
 
 

 ##########
 File path: phoenix-core/src/main/java/org/apache/phoenix/parse/AlterIndexStatement.java
 ##########
 @@ -28,19 +28,21 @@
     private final boolean ifExists;
     private final PIndexState indexState;
     private boolean async;
+    private boolean isRebuildAll;
     private ListMultimap<String,Pair<String,Object>> props;
     private static final PTableType tableType=PTableType.INDEX;
 
-    public AlterIndexStatement(NamedTableNode indexTableNode, String dataTableName, boolean
ifExists, PIndexState indexState, boolean async) {
-        this(indexTableNode,dataTableName,ifExists,indexState,async,null);
+    public AlterIndexStatement(NamedTableNode indexTableNode, String dataTableName, boolean
ifExists, PIndexState indexState, boolean isRebuildAll, boolean async) {
+        this(indexTableNode,dataTableName,ifExists,indexState, isRebuildAll, async,null);
 
 Review comment:
   Note: earlier comment about consistent naming of this param

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message