phoenix-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [phoenix] kadirozde commented on a change in pull request #469: PHOENIX-5156 Consistent Global Indexes for Non-Transactional Tables
Date Fri, 17 May 2019 20:33:55 GMT
kadirozde commented on a change in pull request #469: PHOENIX-5156 Consistent Global Indexes
for Non-Transactional Tables
URL: https://github.com/apache/phoenix/pull/469#discussion_r285279734
 
 

 ##########
 File path: phoenix-core/src/main/java/org/apache/phoenix/util/UpgradeUtil.java
 ##########
 @@ -1418,6 +1420,14 @@ public static void syncTableAndIndexProperties(PhoenixConnection conn,
Admin adm
                 continue;
             }
             if (table.getType() == PTableType.INDEX) {
+                if (table.getIndexType() == IndexType.GLOBAL &&
+                        !table.isTransactional() &&
+                        !table.isImmutableRows() &&
+                        !origTableDesc.hasCoprocessor(GlobalIndexChecker.class.getName()))
{
+                    TableDescriptorBuilder builder = TableDescriptorBuilder.newBuilder(origTableDesc);
+                    builder.addCoprocessor(GlobalIndexChecker.class.getName(), null, QueryServicesOptions.DEFAULT_COPROCESSOR_PRIORITY
- 1, null);
 
 Review comment:
   I have already removed this code in my private branch and will be removed in the next patch.
I am waiting for the next code review comments to do that.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message