phoenix-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [phoenix] kadirozde commented on a change in pull request #469: PHOENIX-5156 Consistent Global Indexes for Non-Transactional Tables
Date Thu, 09 May 2019 20:59:50 GMT
kadirozde commented on a change in pull request #469: PHOENIX-5156 Consistent Global Indexes
for Non-Transactional Tables
URL: https://github.com/apache/phoenix/pull/469#discussion_r282652248
 
 

 ##########
 File path: phoenix-core/src/main/java/org/apache/phoenix/hbase/index/Indexer.java
 ##########
 @@ -579,16 +798,79 @@ public void postBatchMutateIndispensably(ObserverContext<RegionCoprocessorEnviro
 
   private void doPost(ObserverContext<RegionCoprocessorEnvironment> c, BatchMutateContext
context) throws IOException {
       try {
-        doPostWithExceptions(c,context);
-        return;
+          doPostWithExceptions(c,context);
+          return;
       } catch (Throwable e) {
-        rethrowIndexingException(e);
+          rethrowIndexingException(e);
       }
       throw new RuntimeException(
-          "Somehow didn't complete the index update, but didn't return succesfully either!");
-    }
+              "Somehow didn't complete the index update, but didn't return succesfully either!");
+  }
 
   private void doPostWithExceptions(ObserverContext<RegionCoprocessorEnvironment> c,
BatchMutateContext context)
+            throws IOException {
 
 Review comment:
   Done

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message