phoenix-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [phoenix] gjacoby126 commented on a change in pull request #495: PHOENIX-4703 Make indextool changes to drop before rebuild
Date Wed, 01 May 2019 22:23:51 GMT
gjacoby126 commented on a change in pull request #495: PHOENIX-4703 Make indextool changes
to drop before rebuild
URL: https://github.com/apache/phoenix/pull/495#discussion_r280237092
 
 

 ##########
 File path: phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java
 ##########
 @@ -4302,6 +4302,7 @@ public MutationState alterIndex(AlterIndexStatement statement) throws
SQLExcepti
             boolean changingPhoenixTableProperty= evaluateStmtProperties(metaProperties,metaPropertiesEvaluated,table,schemaName,tableName);
 
             PIndexState newIndexState = statement.getIndexState();
+            // TODO: Change this for PHOENIX-4703
 
 Review comment:
   I'm guessing you can just revert MetaDataClient from this PR, @gokceni , since you deferred
the SQL changes to a subsequent JIRA.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message