From issues-return-6117-archive-asf-public=cust-asf.ponee.io@phoenix.apache.org Thu Apr 18 00:50:03 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id BA883180672 for ; Thu, 18 Apr 2019 02:50:02 +0200 (CEST) Received: (qmail 67319 invoked by uid 500); 18 Apr 2019 00:50:02 -0000 Mailing-List: contact issues-help@phoenix.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@phoenix.apache.org Delivered-To: mailing list issues@phoenix.apache.org Received: (qmail 67307 invoked by uid 99); 18 Apr 2019 00:50:02 -0000 Received: from mailrelay1-us-west.apache.org (HELO mailrelay1-us-west.apache.org) (209.188.14.139) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 18 Apr 2019 00:50:02 +0000 Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id E6868E2AD3 for ; Thu, 18 Apr 2019 00:50:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 43C8F2459F for ; Thu, 18 Apr 2019 00:50:00 +0000 (UTC) Date: Thu, 18 Apr 2019 00:50:00 +0000 (UTC) From: "Hadoop QA (JIRA)" To: issues@phoenix.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (PHOENIX-5247) DROP TABLE and DROP VIEW commands fail to drop second or higher level child views MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/PHOENIX-5247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16820618#comment-16820618 ] Hadoop QA commented on PHOENIX-5247: ------------------------------------ {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12966300/PHOENIX-5247.4.14.1-HBase-1.2.001.patch against master branch at commit 2e12af8e0d8c58a7ad4178b0476057d02fb1a7a3. ATTACHMENT ID: 12966300 {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:red}-1 tests included{color}. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. {color:red}-1 patch{color}. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-PHOENIX-Build/2513//console This message is automatically generated. > DROP TABLE and DROP VIEW commands fail to drop second or higher level child views > --------------------------------------------------------------------------------- > > Key: PHOENIX-5247 > URL: https://issues.apache.org/jira/browse/PHOENIX-5247 > Project: Phoenix > Issue Type: Bug > Affects Versions: 4.14.2 > Reporter: Kadir OZDEMIR > Assignee: Kadir OZDEMIR > Priority: Major > Fix For: 4.14.2 > > Attachments: PHOENIX-5247.4.14.1-HBase-1.2.001.patch > > > We have seen large number of orphan views in our production environments. The method (doDropTable) that is used to drop tables and views drops only the first level child views of tables. This seems to be the main root cause for orphan views. doDropTable() is recursive only when the table type is TABLE or SYSTEM. The table type for views is VIEW. The findChildViews method returns the first level child views. So, doDropTable ignores dropping views of views (i.e., second or higher level views). -- This message was sent by Atlassian JIRA (v7.6.3#76005)