From issues-return-6176-archive-asf-public=cust-asf.ponee.io@phoenix.apache.org Sat Apr 20 01:44:02 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 0C0C1180675 for ; Sat, 20 Apr 2019 03:44:01 +0200 (CEST) Received: (qmail 99053 invoked by uid 500); 20 Apr 2019 01:44:01 -0000 Mailing-List: contact issues-help@phoenix.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@phoenix.apache.org Delivered-To: mailing list issues@phoenix.apache.org Received: (qmail 99042 invoked by uid 99); 20 Apr 2019 01:44:01 -0000 Received: from mailrelay1-us-west.apache.org (HELO mailrelay1-us-west.apache.org) (209.188.14.139) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 20 Apr 2019 01:44:01 +0000 Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id DBD20E2AEF for ; Sat, 20 Apr 2019 01:44:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 4B4B725812 for ; Sat, 20 Apr 2019 01:44:00 +0000 (UTC) Date: Sat, 20 Apr 2019 01:44:00 +0000 (UTC) From: "Hudson (JIRA)" To: issues@phoenix.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (PHOENIX-5246) PhoenixAccessControllers.getAccessControllers() method is not correctly implementing the double-checked locking MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/PHOENIX-5246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16822309#comment-16822309 ] Hudson commented on PHOENIX-5246: --------------------------------- FAILURE: Integrated in Jenkins build PreCommit-PHOENIX-Build #2521 (See [https://builds.apache.org/job/PreCommit-PHOENIX-Build/2521/]) PHOENIX-5246: PhoenixAccessControllers.getAccessControllers() method is (tdsilva: rev 2e98269dd94f17fa01437065f36f26ef12a49dba) * (edit) phoenix-core/src/main/java/org/apache/phoenix/coprocessor/PhoenixAccessController.java > PhoenixAccessControllers.getAccessControllers() method is not correctly implementing the double-checked locking > --------------------------------------------------------------------------------------------------------------- > > Key: PHOENIX-5246 > URL: https://issues.apache.org/jira/browse/PHOENIX-5246 > Project: Phoenix > Issue Type: Bug > Affects Versions: 4.14.0 > Reporter: Thomas D'Silva > Assignee: Swaroopa Kadam > Priority: Major > Labels: SFDC > Fix For: 4.15.0, 5.1.0, 4.14.2 > > Attachments: PHOENIX-5246.4.x-HBase-1.3.v1.patch > > Time Spent: 0.5h > Remaining Estimate: 0h > > By [~elserj] on PHOENIX-5070: > This looks to me that the getAccessControllers() method is not correctly implementing the double-checked locking "approach" as per https://en.wikipedia.org/wiki/Double-checked_locking#Usage_in_Java (the accessControllers variable must be volatile). > If we want to avoid taking an explicit lock, what about using AtomicReference instead? Can we spin out another Jira issue to fix that? -- This message was sent by Atlassian JIRA (v7.6.3#76005)