From issues-return-6033-archive-asf-public=cust-asf.ponee.io@phoenix.apache.org Mon Apr 15 18:47:19 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id E236F18064C for ; Mon, 15 Apr 2019 20:47:18 +0200 (CEST) Received: (qmail 78445 invoked by uid 500); 15 Apr 2019 18:47:18 -0000 Mailing-List: contact issues-help@phoenix.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@phoenix.apache.org Delivered-To: mailing list issues@phoenix.apache.org Received: (qmail 78436 invoked by uid 99); 15 Apr 2019 18:47:18 -0000 Received: from Unknown (HELO mailrelay1-us-west.apache.org) (209.188.14.139) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 15 Apr 2019 18:47:18 +0000 Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 90BA7E2AC7 for ; Mon, 15 Apr 2019 18:47:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 19F672459A for ; Mon, 15 Apr 2019 18:47:00 +0000 (UTC) Date: Mon, 15 Apr 2019 18:47:00 +0000 (UTC) From: "Chinmay Kulkarni (JIRA)" To: issues@phoenix.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (PHOENIX-5243) PhoenixResultSet#next() closes the result set if scanner returns null MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/PHOENIX-5243?page=3Dcom.atlassi= an.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D16= 818271#comment-16818271 ]=20 Chinmay Kulkarni commented on PHOENIX-5243: ------------------------------------------- [~swaroopa]=C2=A0Thanks for the patch. Can you please describe how you ran = into this issue wherein the ResultSet object continued to be used even afte= r getting a null current row? Brief offline discussion pointed towards some= thing via in SQLline, if so, we may have to make changes in SQLline as well= . Please confirm. Also, in your patch, it would be cleaner if we returned in only 1 spot. We = currently already do: {code:java} return currentRow !=3D null {code} which would suffice for your case as well. We=C2=A0should instead change th= e existing=C2=A0_else_=C2=A0condition to {code:java} if (currentRow !=3D null) { count++; ..... } {code} this will also ensure that the current functionality of resetting the row p= rojector, etc. would stay unchanged. > PhoenixResultSet#next() closes the result set if scanner returns null > --------------------------------------------------------------------- > > Key: PHOENIX-5243 > URL: https://issues.apache.org/jira/browse/PHOENIX-5243 > Project: Phoenix > Issue Type: Bug > Reporter: Swaroopa Kadam > Assignee: Swaroopa Kadam > Priority: Minor > Fix For: 4.14.2 > > Attachments: PHOENIX-5243.4.x-HBase-1.3.v1.patch > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)