From issues-return-5858-archive-asf-public=cust-asf.ponee.io@phoenix.apache.org Wed Apr 10 18:13:05 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id BB6A4180763 for ; Wed, 10 Apr 2019 20:13:04 +0200 (CEST) Received: (qmail 52208 invoked by uid 500); 10 Apr 2019 18:13:02 -0000 Mailing-List: contact issues-help@phoenix.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@phoenix.apache.org Delivered-To: mailing list issues@phoenix.apache.org Received: (qmail 52148 invoked by uid 99); 10 Apr 2019 18:13:02 -0000 Received: from mailrelay1-us-west.apache.org (HELO mailrelay1-us-west.apache.org) (209.188.14.139) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 10 Apr 2019 18:13:02 +0000 Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 5054CE2A6F for ; Wed, 10 Apr 2019 18:13:01 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id C2C8B2459F for ; Wed, 10 Apr 2019 18:13:00 +0000 (UTC) Date: Wed, 10 Apr 2019 18:13:00 +0000 (UTC) From: "Josh Elser (JIRA)" To: issues@phoenix.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (PHOENIX-5213) Phoenix-client improvements: add more relocations, exclude log binding, add source jar MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/PHOENIX-5213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16814739#comment-16814739 ] Josh Elser commented on PHOENIX-5213: ------------------------------------- {quote}FWIW we don't actually have a slf4j-log4j12 dependency defined anywhere in our poms. {quote} This should be something we add ourselves, since the expectation of Phoenix is that we're using Log4j as the logging implementation. Probably in phoenix-client makes the most sense (since we expect it to be there in the pheonix-client artifact). Nit picky and not something you need to fix here. {quote}Btw, on #3, I still don't think there's a way to change the naming convention in the repo. Again, you can change the jar name when it's created in /target , which can then be bundled in the assembly tarball, but when installing to the repo, it is always renamed to artifact-version.jar . So we still have that inconsistency. {quote} I'm surprised looking at the output of the build given your previous comment: {noformat} $ ll phoenix-client/target total 563656 drwxr-xr-x 3 jelser staff 96B Apr 10 13:52 classes drwxr-xr-x 3 jelser staff 96B Apr 10 13:52 maven-archiver drwxr-xr-x 3 jelser staff 96B Apr 10 13:52 maven-shared-archive-resources -rw-r--r-- 1 jelser staff 13K Apr 10 13:52 original-phoenix-4.15.0-HBase-1.4-SNAPSHOT-client.jar -rw-r--r-- 1 jelser staff 103M Apr 10 13:54 phoenix-4.15.0-HBase-1.4-SNAPSHOT-client-embedded.jar -rw-r--r-- 1 jelser staff 103M Apr 10 13:53 phoenix-4.15.0-HBase-1.4-SNAPSHOT-client.jar -rw-r--r-- 1 jelser staff 51M Apr 10 13:54 phoenix-client-4.15.0-HBase-1.4-SNAPSHOT-embedded-sources.jar {noformat} I thought you were saying that Maven wasn't doing what you needed when the renaming was happening. Did you decide to just leave the naming as it was before? Everything good in how you wanted to use/reference this artifact downstream from Phoenix? > Phoenix-client improvements: add more relocations, exclude log binding, add source jar > --------------------------------------------------------------------------------------- > > Key: PHOENIX-5213 > URL: https://issues.apache.org/jira/browse/PHOENIX-5213 > Project: Phoenix > Issue Type: Improvement > Affects Versions: 5.0.0, 4.15.0 > Reporter: Vincent Poon > Assignee: Vincent Poon > Priority: Major > Attachments: PHOENIX-5213.4.x-HBase-1.4.v1.patch, PHOENIX-5213.4.x-HBase-1.4.v2.patch > > > To make the existing phoenix-client, I'm proposing the following changes: > 1) Add additional relocations of some packages > Add a new "embedded" classifier to phoenix-client that does the following: > 2) Exclude the slf4j-log4j12 binding. Apparently this isn't pulled in directly from phoenix-core itself, but transitively from other projects. It's generally considered best practice to not impose a log binding on downstream projects. The slf4j-log4j12 jar will still be in the phoenix tarball's /lib folder. > 3) Create a source jar for phoenix-client embedded. > 4) Create a dependency-reduced pom, so that the client can be used directly in downstream projects without having to exclude transitive artifacts. -- This message was sent by Atlassian JIRA (v7.6.3#76005)